Skip to content

Commit fb27a9e

Browse files
committed
Tighten the type discriminators.
Some of them are looser than necessary. This won't constitute a breaking change, as the resulting field type will be the same, just without using the polymorphic decoding. The idea is to increase precision, as well as allow us to drop unnecessary type discriminators from the payload in the future.
1 parent 52e25a6 commit fb27a9e

File tree

3 files changed

+5
-5
lines changed

3 files changed

+5
-5
lines changed

src/citrine/__version__.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
__version__ = "3.2.14"
1+
__version__ = "3.2.15"

src/citrine/informatics/predictors/chemical_formula_featurizer.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33
from citrine._rest.resource import Resource
44
from citrine._serialization import properties
5-
from citrine.informatics.descriptors import ChemicalFormulaDescriptor, Descriptor
5+
from citrine.informatics.descriptors import ChemicalFormulaDescriptor
66
from citrine.informatics.predictors import PredictorNode
77

88
__all__ = ['ChemicalFormulaFeaturizer']
@@ -130,7 +130,7 @@ class ChemicalFormulaFeaturizer(Resource["ChemicalFormulaFeaturizer"], Predictor
130130
131131
"""
132132

133-
input_descriptor = properties.Object(Descriptor, 'input')
133+
input_descriptor = properties.Object(ChemicalFormulaDescriptor, 'input')
134134
features = properties.List(properties.String, 'features')
135135
excludes = properties.List(properties.String, 'excludes', default=[])
136136
powers = properties.List(properties.Integer, 'powers')

src/citrine/informatics/predictors/molecular_structure_featurizer.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55

66
from citrine._rest.resource import Resource
77
from citrine._serialization import properties as _properties
8-
from citrine.informatics.descriptors import Descriptor, MolecularStructureDescriptor
8+
from citrine.informatics.descriptors import MolecularStructureDescriptor
99
from citrine.informatics.predictors import PredictorNode
1010

1111
__all__ = ['MolecularStructureFeaturizer']
@@ -78,7 +78,7 @@ class MolecularStructureFeaturizer(Resource["MolecularStructureFeaturizer"], Pre
7878
7979
"""
8080

81-
input_descriptor = _properties.Object(Descriptor, 'descriptor')
81+
input_descriptor = _properties.Object(MolecularStructureDescriptor, 'descriptor')
8282
features = _properties.List(_properties.String, 'features')
8383
excludes = _properties.List(_properties.String, 'excludes')
8484

0 commit comments

Comments
 (0)