Skip to content

Commit f169b66

Browse files
committed
few qol fixes
1 parent b59760e commit f169b66

File tree

4 files changed

+8
-4
lines changed

4 files changed

+8
-4
lines changed

api/admin.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,4 +22,4 @@ class DatasetAdmin(admin.ModelAdmin):
2222
class UseCaseAdmin(admin.ModelAdmin):
2323
list_display = ("title", "slug", "created")
2424
search_fields = ("title", "slug")
25-
search_fields = ("title", "summary")
25+
list_filter = ("organization",)

api/models/Dataset.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ class Dataset(models.Model):
4040
)
4141
user = models.ForeignKey(
4242
"authorization.User",
43-
on_delete=models.CASCADE,
43+
on_delete=models.SET_NULL,
4444
null=True,
4545
blank=True,
4646
related_name="datasets",

api/schema/base_mutation.py

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@
1616
)
1717

1818
import strawberry
19+
import structlog
1920
from django.core.exceptions import PermissionDenied
2021
from django.core.exceptions import ValidationError as DjangoValidationError
2122
from django.db import DataError, IntegrityError
@@ -31,6 +32,8 @@
3132
from api.utils.graphql_telemetry import trace_resolver
3233
from authorization.activity import record_activity
3334

35+
logger = structlog.getLogger(__name__)
36+
3437
# Type aliases
3538
ActivityData = Dict[str, Any]
3639
ActivityDataGetter = Callable[[Any, Dict[str, Any]], ActivityData] # type: ignore
@@ -231,6 +234,7 @@ def wrapper(
231234
except Exception as e:
232235
# Log the error but don't expose internal details
233236
error_message = "An unexpected error occurred"
237+
logger.error("mutation_failed", error=str(e))
234238
errors = GraphQLValidationError.from_message(error_message)
235239
return MutationResponse.error_response(errors) # type: ignore
236240

api/schema/dataset_schema.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -638,9 +638,9 @@ def update_dataset(
638638
raise ValueError(f"Dataset with ID {dataset_id} does not exist.")
639639
if dataset.status != DatasetStatus.DRAFT.value:
640640
raise ValueError(f"Dataset with ID {dataset_id} is not in draft status.")
641-
if update_dataset_input.title.strip() == "":
642-
raise ValueError("Title cannot be empty.")
643641
if update_dataset_input.title:
642+
if update_dataset_input.title.strip() == "":
643+
raise ValueError("Title cannot be empty.")
644644
dataset.title = update_dataset_input.title.strip()
645645
if update_dataset_input.description:
646646
dataset.description = update_dataset_input.description.strip()

0 commit comments

Comments
 (0)