scripts/visualize-builds.py: Satisfy ruff and pylint

  scripts/visualize-builds.py:169:23: SIM115 Use a context manager for opening files
      |
  167 |     output_file = None
  168 |     if args.output:
  169 |         output_file = open(args.output, "w", newline="")
      |                       ^^^^ SIM115
  170 |
  171 |     try:
      |

  scripts/visualize-builds.py:176:9: PLR5501 [*] Use `elif` instead of `else` then `if`, to reduce indentation
      |
  174 |           elif args.format == "pretty":
  175 |               output_pretty_table(days, output_file)
  176 | /         else:  # regular table
  177 | |             if (
      | |____________^ PLR5501
  178 |                   output_file
  179 |               ):  # evil hack so I don't have to rewrite visualize_data() prints
      |
      = help: Convert to `elif`

  Found 2 errors.

  ************* Module visualize-builds
  scripts/visualize-builds.py:169:22: W1514: Using open without explicitly specifying an encoding (unspecified-encoding)
  scripts/visualize-builds.py:169:22: R1732: Consider using 'with' for resource-allocating operations (consider-using-with)

Signed-off-by: Nathan Chancellor <[email protected]>

Author: nathanchance

scripts/visualize-builds.py

@@ -164,23 +164,24 @@ def main():
 
     output_file = None
     if args.output:
-        output_file = open(args.output, "w", newline="")
+        # pylint: disable-next=consider-using-with
+        output_file = open(  # noqa: SIM115
+            args.output, "w", encoding="utf-8", newline="")
 
     try:
         if args.format == "csv":
             output_csv(days, output_file)
         elif args.format == "pretty":
             output_pretty_table(days, output_file)
-        else:  # regular table
-            if (
-                    output_file
-            ):  # evil hack so I don't have to rewrite visualize_data() prints
-                original_stdout = sys.stdout
-                sys.stdout = output_file
-                visualize_data(days)
-                sys.stdout = original_stdout
-            else:
-                visualize_data(days)
+        # regular table
+        elif output_file:
+            # evil hack so I don't have to rewrite visualize_data() prints
+            original_stdout = sys.stdout
+            sys.stdout = output_file
+            visualize_data(days)
+            sys.stdout = original_stdout
+        else:
+            visualize_data(days)
     finally:
         if output_file:
             output_file.close()