Fix internal logging and problem matching #856
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nathanchance
requested review from
JustinStitt,
bwendling and
nickdesaulniers
as code owners
There were two problems with the recently merged internal logging improvements: 1. I assumed that print_yellow() was only called when warning but it is also used for informational prints. 2. The regex did not work. Simplify the regex by avoiding brackets and just using a simple ERROR: and WARNING: prefix to the message. Introduce new logging functions: die() to print a message and exit with error code 1, warn() to print a warning, and info() to print information. Use these consistently throughout the scripts. Adjust certain messages so that they will be caught by the new problem matcher. Signed-off-by: Nathan Chancellor <[email protected]>
nathanchance
force-pushed
the
fix-internal-logging
branch
from
e08e106 to
6db3475
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were two problems with the recently merged internal logging improvements:
print_yellow()was only called when warning but it is also used for informational prints.Simplify the regex by avoiding brackets and just using a simple
ERROR:andWARNING:prefix to the message.Introduce new logging functions:
die()to print a message and exit with error code 1,warn()to print a warning, andinfo()to print information. Use these consistently throughout the scripts. Adjust certain messages so that they will be caught by the new problem matcher.