Skip to content

Commit baef422

Browse files
authored
perf: eliminate redundant query after memory update (open-webui#21013)
## Summary Eliminates redundant database query in update_memory_by_id_and_user_id. Previously, after modifying the memory object, it called get_memory_by_id which opened a new session and queried again. ## Changes models/memories.py update_memory_by_id_and_user_id: - Replace self.get_memory_by_id(id) with db.refresh(memory) - Return the same memory object that was already modified ## Performance Impact Before: 2 queries (get + get_memory_by_id) After: 1 query + refresh on same session
1 parent 68e2578 commit baef422

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

backend/open_webui/models/memories.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -82,7 +82,8 @@ def update_memory_by_id_and_user_id(
8282
memory.updated_at = int(time.time())
8383

8484
db.commit()
85-
return self.get_memory_by_id(id)
85+
db.refresh(memory)
86+
return MemoryModel.model_validate(memory)
8687
except Exception:
8788
return None
8889

0 commit comments

Comments
 (0)