Fix workflow action type and optional issue

Shellishack · Shellishack · commit 1ad9a5ad8449 · 2025-11-15T18:48:01.000+08:00
diff --git a/.changeset/afraid-rockets-camp.md b/.changeset/afraid-rockets-camp.md
@@ -0,0 +1,6 @@
+---
+"@pulse-editor/shared-utils": patch
+"@pulse-editor/react-api": patch
+---
+
+Allow optional args for workflow handler
diff --git a/.changeset/pre.json b/.changeset/pre.json
@@ -10,6 +10,7 @@
   },
   "changesets": [
     "afraid-moments-punch",
+    "afraid-rockets-camp",
     "angry-llamas-smash",
     "beige-pandas-rhyme",
     "beige-pumas-run",
@@ -50,6 +51,7 @@
     "real-knives-rest",
     "rude-ducks-design",
     "sad-tables-join",
+    "shaggy-geckos-bow",
     "sharp-memes-give",
     "shiny-doodles-jump",
     "silent-glasses-kick",
diff --git a/.changeset/shaggy-geckos-bow.md b/.changeset/shaggy-geckos-bow.md
@@ -0,0 +1,6 @@
+---
+"@pulse-editor/shared-utils": patch
+"@pulse-editor/react-api": patch
+---
+
+Fix object type issue in typed variable
diff --git a/npm-packages/react-api/CHANGELOG.md b/npm-packages/react-api/CHANGELOG.md
@@ -1,5 +1,21 @@
 # @pulse-editor/react-api
 
+## 0.1.1-beta.59
+
+### Patch Changes
+
+- Fix object type issue in typed variable
+- Updated dependencies
+  - @pulse-editor/shared-utils@0.1.1-beta.59
+
+## 0.1.1-beta.58
+
+### Patch Changes
+
+- Allow optional args for workflow handler
+- Updated dependencies
+  - @pulse-editor/shared-utils@0.1.1-beta.58
+
 ## 0.1.1-beta.57
 
 ### Patch Changes
diff --git a/npm-packages/react-api/package.json b/npm-packages/react-api/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@pulse-editor/react-api",
-  "version": "0.1.1-beta.57",
+  "version": "0.1.1-beta.59",
   "main": "dist/main.js",
   "files": [
     "dist"
@@ -37,7 +37,7 @@
     "typescript-eslint": "^8.30.1"
   },
   "peerDependencies": {
-    "@pulse-editor/shared-utils": "0.1.1-beta.57",
+    "@pulse-editor/shared-utils": "0.1.1-beta.59",
     "react": "^19.0.0",
     "react-dom": "^19.0.0"
   },
diff --git a/npm-packages/react-api/src/hooks/editor/use-register-action.ts b/npm-packages/react-api/src/hooks/editor/use-register-action.ts
@@ -123,9 +123,14 @@ export default function useRegisterAction(
           }
           // Validate parameters
           const actionParams = actionInfo.parameters ?? {};
-          if (Object.keys(args).length !== Object.keys(actionParams).length) {
+
+          const requiredParamCount = Object.entries(actionParams).filter(
+            ([, paramInfo]) => !(paramInfo as TypedVariable).optional,
+          ).length;
+
+          if (Object.keys(args).length < requiredParamCount) {
             throw new Error(
-              `Invalid number of parameters: expected ${
+              `Invalid number of parameters: expected at least${
                 Object.keys(actionParams).length
               }, got ${Object.keys(args).length}`,
             );
diff --git a/npm-packages/shared-utils/CHANGELOG.md b/npm-packages/shared-utils/CHANGELOG.md
@@ -1,5 +1,17 @@
 # @pulse-editor/shared-utils
 
+## 0.1.1-beta.59
+
+### Patch Changes
+
+- Fix object type issue in typed variable
+
+## 0.1.1-beta.58
+
+### Patch Changes
+
+- Allow optional args for workflow handler
+
 ## 0.1.1-beta.57
 
 ### Patch Changes
diff --git a/npm-packages/shared-utils/package.json b/npm-packages/shared-utils/package.json
@@ -1,6 +1,6 @@
 {
     "name": "@pulse-editor/shared-utils",
-    "version": "0.1.1-beta.57",
+    "version": "0.1.1-beta.59",
     "main": "dist/main.js",
     "files": [
         "dist"
diff --git a/npm-packages/shared-utils/src/types/types.ts b/npm-packages/shared-utils/src/types/types.ts
@@ -215,7 +215,7 @@ export type TypedVariableType =
   | "string"
   | "number"
   | "boolean"
-  | "any"
+  | "object"
   // An app instance is a reference to another app.
   // This instance could be possessed by the owner,
   // or it can be initialized by the caller.
diff --git a/web/components/marketplace/app/app-preview-card.tsx b/web/components/marketplace/app/app-preview-card.tsx
@@ -362,8 +362,8 @@ export default function AppPreviewCard({
               <Button
                 color="primary"
                 size="sm"
-                onPress={(e) => {
-                  installExtension(
+                onPress={async (e) => {
+                  await installExtension(
                     extension.remoteOrigin,
                     extension.config.id,
                     extension.config.version,
diff --git a/web/components/views/canvas/nodes/app-node/layout.tsx b/web/components/views/canvas/nodes/app-node/layout.tsx
@@ -404,6 +404,7 @@ function InputHandle({
           paramName={paramName}
           node={node}
           editorContext={editorContext}
+          isOptional={param.optional ?? false}
         />
       </div>
     );
@@ -414,6 +415,7 @@ function InputHandle({
         param={param}
         position={Position.Left}
         type="target"
+        isOptional={param.optional ?? false}
       />
     );
   }
@@ -423,10 +425,12 @@ function DroppableInputHandle({
   paramName,
   node,
   editorContext,
+  isOptional,
 }: {
   paramName: string;
   node: ReactFlowNode<AppNodeData>;
   editorContext: EditorContextType | undefined;
+  isOptional: boolean;
 }) {
   const { updateNodeData } = useReactFlow();
 
@@ -456,6 +460,7 @@ function DroppableInputHandle({
       <div className="py-2 text-center">
         <p>{paramName}</p>
         <p>(app-instance)</p>
+        {!isOptional && <p className="text-danger">*required</p>}
         {node.data.ownedAppViews[paramName] ? (
           <p>{node.data.ownedAppViews[paramName].viewId}</p>
         ) : (
diff --git a/web/components/views/canvas/nodes/app-node/node-handle.tsx b/web/components/views/canvas/nodes/app-node/node-handle.tsx
@@ -6,11 +6,13 @@ export default function NodeHandle({
   param,
   position,
   type,
+  isOptional,
 }: {
   id: string;
   param: TypedVariable;
   position: Position;
   type: HandleType;
+  isOptional?: boolean;
 }) {
   return (
     <div
@@ -21,6 +23,7 @@ export default function NodeHandle({
       <div className="text-center text-sm">
         <p>{id}</p>
         <p>({param?.type.toString()})</p>
+        {isOptional !== undefined && !isOptional && <p className="text-danger">*required</p>}
       </div>
       <Handle
         id={id}
diff --git a/web/lib/hooks/use-extension-manager.ts b/web/lib/hooks/use-extension-manager.ts
@@ -65,7 +65,7 @@ export default function useExtensionManager() {
       );
 
       const installedExtensions =
-        (await editorContext?.persistSettings?.extensions) ?? [];
+        editorContext?.persistSettings?.extensions ?? [];
 
       // Check if extension is already installed
       if (

Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,6 @@`
`1`	`1`	`{`
`2`	`2`	`"name": "@pulse-editor/shared-utils",`
`3`		`- "version": "0.1.1-beta.57",`
	`3`	`+ "version": "0.1.1-beta.59",`
`4`	`4`	`"main": "dist/main.js",`
`5`	`5`	`"files": [`
`6`	`6`	`"dist"`