Support code workflow

Shellishack · Shellishack · commit dee2c260a031 · 2025-10-19T00:39:24.000+08:00
diff --git a/.changeset/pre.json b/.changeset/pre.json
@@ -59,6 +59,7 @@
     "social-donkeys-cross",
     "soft-cases-share",
     "stale-groups-poke",
+    "sunny-symbols-flash",
     "tender-jeans-occur",
     "tender-phones-ring",
     "tough-aliens-appear",
diff --git a/.changeset/sunny-symbols-flash.md b/.changeset/sunny-symbols-flash.md
@@ -0,0 +1,6 @@
+---
+"@pulse-editor/shared-utils": patch
+"@pulse-editor/react-api": patch
+---
+
+Fix imc intent typo
diff --git a/npm-packages/cli/package.json b/npm-packages/cli/package.json
@@ -1,6 +1,6 @@
 {
 	"name": "@pulse-editor/cli",
-	"version": "0.1.0-beta.4",
+	"version": "0.1.0-beta.5",
 	"license": "MIT",
 	"bin": {
 		"pulse": "./dist/cli.js"
diff --git a/npm-packages/cli/source/components/commands/create.tsx b/npm-packages/cli/source/components/commands/create.tsx
@@ -57,9 +57,14 @@ export default function Create({cli}: {cli: Result<Flags>}) {
 
 	useEffect(() => {
 		if (framework) {
-			setIsShowProjectNameInput(true);
+			const name = cli.flags.name;
+			if (name) {
+				setProjectName(name);
+			} else {
+				setIsShowProjectNameInput(true);
+			}
 		}
-	}, [framework]);
+	}, [framework, cli]);
 
 	useEffect(() => {
 		if (projectName) {
@@ -77,9 +82,14 @@ export default function Create({cli}: {cli: Result<Flags>}) {
 				return;
 			}
 
-			setIsShowVisibilitySelect(true);
+			const visibility = cli.flags.visibility;
+			if (visibility) {
+				setVisibility(visibility);
+			} else {
+				setIsShowVisibilitySelect(true);
+			}
 		}
-	}, [projectName]);
+	}, [projectName, cli]);
 
 	useEffect(() => {
 		if (visibility && projectName) {
diff --git a/npm-packages/cli/source/lib/cli-flags.ts b/npm-packages/cli/source/lib/cli-flags.ts
@@ -26,6 +26,14 @@ export const flags = defineFlags({
 		type: 'boolean',
 		default: false,
 	},
+	name: {
+		type: 'string',
+		shortFlag: 'n',
+	},
+	visibility: {
+		type: 'string',
+		shortFlag: 'v',
+	},
 });
 
 export type Flags = typeof flags;
diff --git a/npm-packages/cli/source/lib/manual.ts b/npm-packages/cli/source/lib/manual.ts
@@ -38,6 +38,11 @@ const create = `\
                       The framework to use for the new app.
                       Currently available options: react.
                       Future options: vue, angular, etc.
+                    --name, -n [project-name]
+                      The name of the new project.
+                    --visibility, -v [visibility]
+                      The visibility of the new project. Options are private,
+                      public, and unlisted.
 `;
 
 export const commandsManual: Record<string, string> = {
diff --git a/npm-packages/react-api/CHANGELOG.md b/npm-packages/react-api/CHANGELOG.md
@@ -1,5 +1,13 @@
 # @pulse-editor/react-api
 
+## 0.1.1-alpha.54
+
+### Patch Changes
+
+- Fix imc intent typo
+- Updated dependencies
+  - @pulse-editor/shared-utils@0.1.1-alpha.54
+
 ## 0.1.1-alpha.53
 
 ### Patch Changes
diff --git a/npm-packages/react-api/package.json b/npm-packages/react-api/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@pulse-editor/react-api",
-  "version": "0.1.1-alpha.53",
+  "version": "0.1.1-alpha.54",
   "main": "dist/main.js",
   "files": [
     "dist"
@@ -37,7 +37,7 @@
     "typescript-eslint": "^8.30.1"
   },
   "peerDependencies": {
-    "@pulse-editor/shared-utils": "0.1.1-alpha.53",
+    "@pulse-editor/shared-utils": "0.1.1-alpha.54",
     "react": "^19.0.0",
     "react-dom": "^19.0.0"
   }
diff --git a/npm-packages/react-api/src/hooks/editor/use-file.ts b/npm-packages/react-api/src/hooks/editor/use-file.ts
@@ -39,12 +39,12 @@ export default function useFile(uri: string | undefined) {
         });
       }
     },
-    [uri, file, isReady]
+    [uri, file, isReady],
   );
 
   // Read file when uri changes
   useEffect(() => {
-    if (isReady) {
+    if (isReady && uri) {
       imc
         ?.sendMessage(IMCMessageTypeEnum.PlatformReadFile, {
           uri,
diff --git a/npm-packages/react-api/src/hooks/editor/use-owned-app-view.ts b/npm-packages/react-api/src/hooks/editor/use-owned-app-view.ts
@@ -1,36 +1,30 @@
 import {
-  AppConfig,
   IMCMessage,
   IMCMessageTypeEnum,
+  ViewModel,
 } from "@pulse-editor/shared-utils";
 import { useCallback } from "react";
 import useIMC from "../imc/use-imc";
 
-export default function useOwnedApp() {
+export default function useOwnedAppView() {
   const receiverHandlerMap = new Map<
     IMCMessageTypeEnum,
     (senderWindow: Window, message: IMCMessage) => Promise<void>
   >([]);
 
   const { imc, isReady } = useIMC(receiverHandlerMap, "owned-app");
 
-  const runOwnedAppAction = useCallback(
-    async (
-      ownedApp: {
-        viewId: string;
-        config: AppConfig;
-      },
-      actionName: string,
-      args: any
-    ) => {
+  const runAppAction = useCallback(
+    async (ownedAppViewModel: ViewModel, actionName: string, args: any) => {
       if (isReady) {
-        const appViewId = ownedApp.viewId;
-        const preRegisteredActions = ownedApp.config.preRegisteredActions || [];
+        const appViewId = ownedAppViewModel.viewId;
+        const preRegisteredActions =
+          ownedAppViewModel.appConfig.preRegisteredActions || [];
 
         const action = preRegisteredActions.find((a) => a.name === actionName);
         if (!action) {
           throw new Error(
-            `Action ${actionName} not found in owned app ${ownedApp.config.id}`
+            `Action ${actionName} not found in owned app ${ownedAppViewModel.appConfig.id}`,
           );
         }
 
@@ -40,16 +34,16 @@ export default function useOwnedApp() {
             viewId: appViewId,
             actionName,
             args,
-          }
+          },
         );
         return result;
       }
       return undefined;
     },
-    [imc, isReady]
+    [imc, isReady],
   );
 
   return {
-    runOwnedAppAction,
+    runAppAction,
   };
 }
diff --git a/npm-packages/react-api/src/hooks/editor/use-register-action.ts b/npm-packages/react-api/src/hooks/editor/use-register-action.ts
@@ -31,7 +31,7 @@ export default function useRegisterAction(
   },
   callbackHandler: (args: any) => Promise<any>,
   deps: DependencyList,
-  isExtReady: boolean = true
+  isExtReady: boolean = true,
 ) {
   const { isReady, imc } = useIMC(getReceiverHandlerMap(), "register-action");
 
@@ -127,7 +127,7 @@ export default function useRegisterAction(
             throw new Error(
               `Invalid number of parameters: expected ${
                 Object.keys(actionParams).length
-              }, got ${Object.keys(args).length}`
+              }, got ${Object.keys(args).length}`,
             );
           }
 
@@ -136,11 +136,16 @@ export default function useRegisterAction(
             if (actionParams[key] === undefined) {
               throw new Error(`Invalid parameter: ${key}`);
             }
-            if (typeof value !== actionParams[key].type) {
+            if (
+              typeof value !== actionParams[key].type &&
+              // Allow object for "app-instance"
+              (actionParams[key].type !== "app-instance" ||
+                typeof value !== "object")
+            ) {
               throw new Error(
                 `Invalid type for parameter ${key}: expected ${
                   actionParams[key].type
-                }, got ${typeof value}. Value received: ${value}`
+                }, got ${typeof value}. Value received: ${value}`,
               );
             }
           }
diff --git a/npm-packages/react-api/src/hooks/imc/use-imc.tsx b/npm-packages/react-api/src/hooks/imc/use-imc.tsx
@@ -30,7 +30,7 @@ export default function useIMC(handlerMap: ReceiverHandlerMap, intent: string) {
       if (!isMounted) return;
       else if (imc !== undefined) return;
 
-      const newImc = new InterModuleCommunication("use-imc", v4());
+      const newImc = new InterModuleCommunication(intent, v4());
       newImc.initThisWindow(window);
       newImc.updateReceiverHandlerMap(handlerMap);
       await newImc.initOtherWindow(targetWindow);
diff --git a/npm-packages/react-api/src/main.ts b/npm-packages/react-api/src/main.ts
@@ -14,7 +14,7 @@ import useSTT from "./hooks/ai-modality/use-stt";
 import useTTS from "./hooks/ai-modality/use-tts";
 import useVideoGen from "./hooks/ai-modality/use-video-gen";
 import usePulseEnv from "./hooks/editor/use-env";
-import useOwnedApp from "./hooks/editor/use-owned-app";
+import useOwnedAppView from "./hooks/editor/use-owned-app-view";
 import useReceiveFile from "./hooks/editor/use-receive-file";
 import useSnapshotState from "./hooks/editor/use-snapshot-state";
 import useTerminal from "./hooks/terminal/use-terminal";
@@ -32,7 +32,7 @@ export {
   useLoading,
   useNotification,
   useOCR,
-  useOwnedApp,
+  useOwnedAppView,
   usePulseEnv,
   useReceiveFile,
   useRegisterAction,
diff --git a/npm-packages/shared-utils/CHANGELOG.md b/npm-packages/shared-utils/CHANGELOG.md
@@ -1,5 +1,11 @@
 # @pulse-editor/shared-utils
 
+## 0.1.1-alpha.54
+
+### Patch Changes
+
+- Fix imc intent typo
+
 ## 0.1.1-alpha.53
 
 ### Patch Changes
diff --git a/npm-packages/shared-utils/package.json b/npm-packages/shared-utils/package.json
@@ -1,6 +1,6 @@
 {
     "name": "@pulse-editor/shared-utils",
-    "version": "0.1.1-alpha.53",
+    "version": "0.1.1-alpha.54",
     "main": "dist/main.js",
     "files": [
         "dist"
diff --git a/npm-packages/shared-utils/src/types/types.ts b/npm-packages/shared-utils/src/types/types.ts
@@ -82,7 +82,7 @@ export type IMCMessage = {
 export type ReceiverHandler = (
   senderWindow: Window,
   message: IMCMessage,
-  abortSignal?: AbortSignal
+  abortSignal?: AbortSignal,
 ) => Promise<any>;
 
 // IMC receiver handler map
@@ -98,7 +98,7 @@ export type TextFileSelection = {
 
 export type ViewModel = {
   viewId: string;
-  appConfig?: AppConfig;
+  appConfig: AppConfig;
 };
 
 export enum ViewModeEnum {
@@ -226,13 +226,13 @@ export type TypedVariableObjectType = {
 export type TypedVariableArrayType = [TypedVariableType];
 
 export function isArrayType(
-  value: TypedVariableType
+  value: TypedVariableType,
 ): value is TypedVariableArrayType {
   return Array.isArray(value) && value.length === 1;
 }
 
 export function isObjectType(
-  value: TypedVariableType
+  value: TypedVariableType,
 ): value is TypedVariableObjectType {
   return typeof value === "object" && !Array.isArray(value);
 }
diff --git a/web/components/explorer/file-system/fs-explorer.tsx b/web/components/explorer/file-system/fs-explorer.tsx
@@ -184,9 +184,6 @@ export default function FileSystemExplorer({
                     projectContent: [],
                   };
                 });
-
-                // Clear view manager
-                closeAllTabViews();
               }}
             >
               <Icon name="close" variant="outlined" />
diff --git a/web/components/providers/imc-provider.tsx b/web/components/providers/imc-provider.tsx
@@ -524,12 +524,20 @@ export default function InterModuleCommunicationProvider({
           }: { viewId: string; actionName: string; args: any } =
             message.payload;
 
-          const result = await polyIMCRef.current?.sendMessage(
-            viewId,
-            IMCMessageTypeEnum.EditorRunAppAction,
-            { name: actionName, args },
-          );
-          return result;
+          const result =
+            (await polyIMCRef.current?.sendMessage(
+              viewId,
+              IMCMessageTypeEnum.EditorRunAppAction,
+              { name: actionName, args },
+            )) ?? [];
+
+          if (result.length !== 1) {
+            console.error(
+              `Expected single result from owned app view ${viewId} for action ${actionName}, but got:`,
+              result,
+            );
+          }
+          return result[0];
         },
       ],
     ]);
diff --git a/web/components/views/canvas/canvas-view.tsx b/web/components/views/canvas/canvas-view.tsx
@@ -127,6 +127,23 @@ export default function CanvasView({
       edges: ReactFlowEdge[];
     }) => {
       if (nodes.length > 0) {
+        // Delete all edges connected to the deleted nodes
+        const connectedEdgeIds = new Set<string>();
+        edges.forEach((edge) => {
+          if (nodes.find((node) => node.id === edge.source)) {
+            connectedEdgeIds.add(edge.id);
+          }
+          if (nodes.find((node) => node.id === edge.target)) {
+            connectedEdgeIds.add(edge.id);
+          }
+        });
+
+        // Delete connected edges
+        updateWorkflowEdges((oldEdges) =>
+          oldEdges.filter((edge) => !connectedEdgeIds.has(edge.id)),
+        );
+
+        // Delete nodes
         const deleteNodePromises = nodes.map(async (node) => {
           await deleteAppViewInCanvasView(node.data.config.viewId);
         });
@@ -211,7 +228,7 @@ export default function CanvasView({
               config.initialWorkflowContent?.nodes.find(
                 (n) => n.id === appConfig.viewId,
               )?.data.isShowingWorkflowConnector ?? false,
-            ownedApps: {}, // Initially no owned apps
+            ownedAppViews: {}, // Initially no owned apps
           };
 
           return {
diff --git a/web/components/views/canvas/nodes/app-node/layout.tsx b/web/components/views/canvas/nodes/app-node/layout.tsx
diff --git a/web/lib/hooks/use-auth.ts b/web/lib/hooks/use-auth.ts
diff --git a/web/lib/hooks/use-canvas-workflow.ts b/web/lib/hooks/use-canvas-workflow.ts
diff --git a/web/lib/types.ts b/web/lib/types.ts

Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,6 @@`
`1`	`1`	`{`
`2`	`2`	`"name": "@pulse-editor/cli",`
`3`		`- "version": "0.1.0-beta.4",`
	`3`	`+ "version": "0.1.0-beta.5",`
`4`	`4`	`"license": "MIT",`
`5`	`5`	`"bin": {`
`6`	`6`	`"pulse": "./dist/cli.js"`