Bug Fixes and Improvements on nbt editor gui#101
Open
KatatsumuriPan wants to merge 8 commits intoCleanroomMC:1.12from
Open
Bug Fixes and Improvements on nbt editor gui#101KatatsumuriPan wants to merge 8 commits intoCleanroomMC:1.12from
KatatsumuriPan wants to merge 8 commits intoCleanroomMC:1.12from
Conversation
KatatsumuriPan
commented
Mar 2, 2024
KatatsumuriPan
commented
- Add up/down button.
- Reduce steps on nbt editor gui.
- Fix the logic inserting a nbt to NBTTagList.
- Remove unnecessary add button on nbt editor.
Member
|
Please fix the merge conflict |
WaitingIdly
requested changes
Mar 20, 2024
Collaborator
WaitingIdly
left a comment
WaitingIdly
left a comment
There was a problem hiding this comment.
this changes the GUI of the Retrieval Task (and its Optional variant), but none of the other tasks. it makes it look out of place, and it seems useful for the other Tasks. the change doesnt appear to be stated in the PR description, so whats going on here? if possible, this should be expanded to the other Tasks
Comment on lines
+86
to
+87
| this.btnUp = btnUp; | ||
| this.btnDown = btnDown; |
Collaborator
There was a problem hiding this comment.
both buttons are active if the length is > 1, even when at the top/bottom and clicking does nothing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.