Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
changes in this PR:
QuestCommandShowworks to useClientChatEvent./bq_client show {quest}send a message in chat sharing the quest.reasoning:
when a player receives a
ClientChatReceivedEventwith the relevant message,QuestCommandShow.sentViaClick = trueis set to true. then, when the message is clicked, custom logic is fired andsentViaClickis set to false. due to this, the first click on a shared quest works properly, but the second doesnt - you only receive the message once. additionally, this means that if you share -> manually run/bq_client show {quest}the command will have no effect.another solution might be to override and create a custom
ClickEvent, so whengetActionis read it is set to be true: