Create recipes using a RecipeBuilder in more situations (#202)

* add more ability to add aspects to infusion and crucible

* add lens to Atomic Reconstructor Recipe Builder

* convert complex add methods to use builder

* make Crucible Recipe Builder register method create recipe

* adjust Elven Trade add shorthand methods

Author: WaitingIdly

src/main/java/com/cleanroommc/groovyscript/compat/mods/actuallyadditions/AtomicReconstructor.java

@@ -13,7 +13,6 @@
 import de.ellpeck.actuallyadditions.api.lens.Lens;
 import de.ellpeck.actuallyadditions.api.recipe.LensConversionRecipe;
 import net.minecraft.item.ItemStack;
-import net.minecraft.item.crafting.Ingredient;
 import org.jetbrains.annotations.Nullable;
 
 @RegistryDescription
@@ -35,10 +34,13 @@ public void onReload() {
         ActuallyAdditionsAPI.RECONSTRUCTOR_LENS_CONVERSION_RECIPES.addAll(restoreFromBackup());
     }
 
-    public LensConversionRecipe add(Ingredient input, ItemStack output, int energy, Lens type) {
-        LensConversionRecipe recipe = new LensConversionRecipe(input, output, energy, type);
-        add(recipe);
-        return recipe;
+    public LensConversionRecipe add(IIngredient input, ItemStack output, int energy, Lens type) {
+        return recipeBuilder()
+                .type(type)
+                .energy(energy)
+                .input(input)
+                .output(output)
+                .register();
     }
 
     public void add(LensConversionRecipe recipe) {
@@ -94,6 +96,8 @@ public static class RecipeBuilder extends AbstractRecipeBuilder<LensConversionRe
 
         @Property(defaultValue = "1", valid = @Comp(type = Comp.Type.GT, value = "0"))
         private int energyUse = 1;
+        @Property(defaultValue = "ActuallyAdditionsAPI.lensDefaultConversion", valid = @Comp(value = "null", type = Comp.Type.NOT))
+        private Lens type = ActuallyAdditionsAPI.lensDefaultConversion;
 
         @RecipeBuilderMethodDescription
         public RecipeBuilder energyUse(int energyUse) {
@@ -107,6 +111,12 @@ public RecipeBuilder energy(int energy) {
             return this;
         }
 
+        @RecipeBuilderMethodDescription
+        public RecipeBuilder type(Lens type) {
+            this.type = type;
+            return this;
+        }
+
         @Override
         public String getErrorMsg() {
             return "Error adding Actually Additions Atomic Reconstructor recipe";
@@ -117,13 +127,14 @@ public void validate(GroovyLog.Msg msg) {
             validateItems(msg, 1, 1, 1, 1);
             validateFluids(msg);
             msg.add(energyUse <= 0, "energyUse must be an integer greater than 0, yet it was {}", energyUse);
+            msg.add(type == null, "type must not be null!");
         }
 
         @Override
         @RecipeBuilderRegistrationMethod
         public @Nullable LensConversionRecipe register() {
             if (!validate()) return null;
-            LensConversionRecipe recipe = new LensConversionRecipe(input.get(0).toMcIngredient(), output.get(0), energyUse, ActuallyAdditionsAPI.lensDefaultConversion);
+            LensConversionRecipe recipe = new LensConversionRecipe(input.get(0).toMcIngredient(), output.get(0), energyUse, type);
             ModSupport.ACTUALLY_ADDITIONS.get().atomicReconstructor.add(recipe);
             return recipe;
         }

src/main/java/com/cleanroommc/groovyscript/compat/mods/alchemistry/Atomizer.java

@@ -33,7 +33,7 @@ public RecipeBuilder recipeBuilder() {
 
     @MethodDescription(type = MethodDescription.Type.ADDITION)
     public AtomizerRecipe add(FluidStack input, ItemStack output) {
-        return new RecipeBuilder().fluidInput(input).output(output).register();
+        return recipeBuilder().fluidInput(input).output(output).register();
     }
 
     public AtomizerRecipe add(AtomizerRecipe recipe) {

src/main/java/com/cleanroommc/groovyscript/compat/mods/alchemistry/Evaporator.java

@@ -32,7 +32,7 @@ public RecipeBuilder recipeBuilder() {
 
     @MethodDescription(type = MethodDescription.Type.ADDITION)
     public EvaporatorRecipe add(FluidStack input, ItemStack output) {
-        return new RecipeBuilder().fluidInput(input).output(output).register();
+        return recipeBuilder().fluidInput(input).output(output).register();
     }
 
     public EvaporatorRecipe add(EvaporatorRecipe recipe) {

src/main/java/com/cleanroommc/groovyscript/compat/mods/alchemistry/Liquifier.java

@@ -32,7 +32,7 @@ public RecipeBuilder recipeBuilder() {
 
     @MethodDescription(type = MethodDescription.Type.ADDITION)
     public LiquifierRecipe add(IIngredient input, FluidStack output) {
-        return new RecipeBuilder().input(input).fluidOutput(output).register();
+        return recipeBuilder().input(input).fluidOutput(output).register();
     }
 
     public LiquifierRecipe add(LiquifierRecipe recipe) {

src/main/java/com/cleanroommc/groovyscript/compat/mods/bloodmagic/AlchemyArray.java

@@ -13,7 +13,6 @@
 import com.cleanroommc.groovyscript.helper.recipe.AbstractRecipeBuilder;
 import com.cleanroommc.groovyscript.registry.VirtualizedRegistry;
 import net.minecraft.item.ItemStack;
-import net.minecraft.item.crafting.Ingredient;
 import net.minecraft.util.ResourceLocation;
 import org.jetbrains.annotations.Nullable;
 
@@ -36,22 +35,27 @@ public void onReload() {
     }
 
     @MethodDescription(description = "groovyscript.wiki.bloodmagic.alchemy_array.add0", type = MethodDescription.Type.ADDITION)
-    public RecipeAlchemyArray add(Ingredient input, Ingredient catalyst, ItemStack output) {
-        RecipeAlchemyArray recipe = new RecipeAlchemyArray(input, catalyst, output, null);
-        add(recipe);
-        return recipe;
+    public RecipeAlchemyArray add(IIngredient input, IIngredient catalyst, ItemStack output) {
+        return recipeBuilder()
+                .catalyst(catalyst)
+                .input(input)
+                .output(output)
+                .register();
     }
 
     @MethodDescription(description = "groovyscript.wiki.bloodmagic.alchemy_array.add1", type = MethodDescription.Type.ADDITION)
-    public RecipeAlchemyArray add(Ingredient input, Ingredient catalyst, ItemStack output, String circleTexture) {
+    public RecipeAlchemyArray add(IIngredient input, IIngredient catalyst, ItemStack output, String circleTexture) {
         return add(input, catalyst, output, new ResourceLocation(circleTexture));
     }
 
     @MethodDescription(description = "groovyscript.wiki.bloodmagic.alchemy_array.add1", type = MethodDescription.Type.ADDITION)
-    public RecipeAlchemyArray add(Ingredient input, Ingredient catalyst, ItemStack output, ResourceLocation circleTexture) {
-        RecipeAlchemyArray recipe = new RecipeAlchemyArray(input, catalyst, output, circleTexture);
-        add(recipe);
-        return recipe;
+    public RecipeAlchemyArray add(IIngredient input, IIngredient catalyst, ItemStack output, ResourceLocation circleTexture) {
+        return recipeBuilder()
+                .catalyst(catalyst)
+                .texture(circleTexture)
+                .input(input)
+                .output(output)
+                .register();
     }
 
     public void add(RecipeAlchemyArray recipe) {

src/main/java/com/cleanroommc/groovyscript/compat/mods/bloodmagic/BloodAltar.java

@@ -14,7 +14,6 @@
 import com.cleanroommc.groovyscript.helper.recipe.AbstractRecipeBuilder;
 import com.cleanroommc.groovyscript.registry.VirtualizedRegistry;
 import net.minecraft.item.ItemStack;
-import net.minecraft.item.crafting.Ingredient;
 import org.jetbrains.annotations.Nullable;
 
 @RegistryDescription(
@@ -44,10 +43,14 @@ public void onReload() {
     }
 
     @MethodDescription(type = MethodDescription.Type.ADDITION)
-    public RecipeBloodAltar add(Ingredient input, ItemStack output, int minimumTier, int syphon, int consumeRate, int drainRate) {
-        RecipeBloodAltar recipe = new RecipeBloodAltar(input, output, minimumTier, syphon, consumeRate, drainRate);
-        add(recipe);
-        return recipe;
+    public RecipeBloodAltar add(IIngredient input, ItemStack output, int minimumTier, int syphon, int consumeRate, int drainRate) {
+        return recipeBuilder()
+                .minimumTier(minimumTier)
+                .consumeRate(consumeRate)
+                .drainRate(drainRate)
+                .input(input)
+                .output(output)
+                .register();
     }
 
     public void add(RecipeBloodAltar recipe) {

src/main/java/com/cleanroommc/groovyscript/compat/mods/bloodmagic/TartaricForge.java

@@ -17,6 +17,7 @@
 import net.minecraft.util.NonNullList;
 import org.jetbrains.annotations.Nullable;
 
+import java.util.Collection;
 import java.util.Collections;
 
 @RegistryDescription
@@ -38,21 +39,13 @@ public void onReload() {
     }
 
     @MethodDescription(type = MethodDescription.Type.ADDITION)
-    public RecipeTartaricForge add(NonNullList<Ingredient> input, ItemStack output, double minimumSouls, double soulDrain) {
-        double minimum;
-        if (minimumSouls < soulDrain) {
-            GroovyLog.msg("Warning creating Blood Magic Tartaric Forge recipe")
-                    .add("minimumSouls should be greater than soulDrain, yet minimumSouls was {} and soulDrain was {}", minimumSouls, soulDrain)
-                    .add("set minimumSouls equal to soulDrain")
-                    .warn()
-                    .post();
-            minimum = soulDrain;
-        } else {
-            minimum = minimumSouls;
-        }
-        RecipeTartaricForge recipe = new RecipeTartaricForge(input, output, minimum, soulDrain);
-        add(recipe);
-        return recipe;
+    public RecipeTartaricForge add(Collection<IIngredient> input, ItemStack output, double minimumSouls, double soulDrain) {
+        return recipeBuilder()
+                .soulDrain(soulDrain)
+                .minimumSouls(minimumSouls)
+                .output(output)
+                .input(input)
+                .register();
     }
 
     public void add(RecipeTartaricForge recipe) {

src/main/java/com/cleanroommc/groovyscript/compat/mods/botania/Apothecary.java

@@ -39,10 +39,10 @@ public void onReload() {
 
     @MethodDescription(type = MethodDescription.Type.ADDITION)
     public RecipePetals add(ItemStack output, IIngredient... inputs) {
-        RecipePetals recipe = new RecipePetals(output, Arrays.stream(inputs).map(i -> i instanceof OreDictIngredient ? ((OreDictIngredient) i).getOreDict()
-                                                                                                                     : i.getMatchingStacks()[0]).toArray());
-        add(recipe);
-        return recipe;
+        return recipeBuilder()
+                .output(output)
+                .input(inputs)
+                .register();
     }
 
     public void add(RecipePetals recipe) {

src/main/java/com/cleanroommc/groovyscript/compat/mods/botania/ElvenTrade.java

@@ -14,6 +14,7 @@
 import vazkii.botania.api.recipe.RecipeElvenTrade;
 
 import java.util.Arrays;
+import java.util.Collection;
 import java.util.List;
 
 @RegistryDescription
@@ -37,15 +38,23 @@ protected Object[] convertIngredients(IIngredient[] inputs) {
     }
 
     @MethodDescription(type = MethodDescription.Type.ADDITION)
-    public RecipeElvenTrade add(ItemStack[] outputs, IIngredient[] inputs) {
-        RecipeElvenTrade recipe = new RecipeElvenTrade(outputs, convertIngredients(inputs));
-        add(recipe);
-        return recipe;
+    public RecipeElvenTrade add(ItemStack[] outputs, IIngredient... inputs) {
+        return recipeBuilder().input(inputs).output(outputs).register();
     }
 
     @MethodDescription(type = MethodDescription.Type.ADDITION)
-    public RecipeElvenTrade add(ItemStack output, IIngredient[] inputs) {
-        return add(new ItemStack[]{output}, inputs);
+    public RecipeElvenTrade add(Collection<ItemStack> outputs, Collection<IIngredient> inputs) {
+        return recipeBuilder().input(inputs).output(outputs).register();
+    }
+
+    @MethodDescription(type = MethodDescription.Type.ADDITION)
+    public RecipeElvenTrade add(ItemStack output, IIngredient... inputs) {
+        return recipeBuilder().input(inputs).output(output).register();
+    }
+
+    @MethodDescription(type = MethodDescription.Type.ADDITION)
+    public RecipeElvenTrade add(ItemStack output, Collection<IIngredient> inputs) {
+        return recipeBuilder().input(inputs).output(output).register();
     }
 
     public void add(RecipeElvenTrade recipe) {

src/main/java/com/cleanroommc/groovyscript/compat/mods/botania/Lexicon.java

@@ -251,14 +251,12 @@ public void onReload() {
 
         @MethodDescription(type = MethodDescription.Type.ADDITION)
         public LexiconEntry add(String name, LexiconCategory category) {
-            LexiconEntry entry = new LexiconEntry(name, category);
-            add(entry);
-            return entry;
+            return entryBuilder().name(name).category(category).register();
         }
 
         @MethodDescription(type = MethodDescription.Type.ADDITION)
         public LexiconEntry add(String name, String category) {
-            return add(name, Botania.getCategory(category));
+            return entryBuilder().name(name).category(category).register();
         }
 
         public void add(LexiconEntry entry) {