fix #153

Author: brachy84

src/main/java/com/cleanroommc/modularui/screen/ClientScreenHandler.java

@@ -79,13 +79,10 @@ public class ClientScreenHandler {
 
     private static IMuiScreen lastMui;
 
-    public static boolean guiIsClosing;
-
     // we need to know the actual gui and not some fake bs some other mod overwrites
     @SubscribeEvent(priority = EventPriority.LOWEST)
     public void onGuiOpen(GuiOpenEvent event) {
         GuiScreen newGui = event.getGui();
-        guiIsClosing = newGui == null;
 
         defaultContext.reset();
         if (lastMui != null && newGui == null) {

src/main/java/com/cleanroommc/modularui/value/sync/ModularSyncManager.java

@@ -1,8 +1,6 @@
 package com.cleanroommc.modularui.value.sync;
 
 import com.cleanroommc.modularui.ModularUI;
-import com.cleanroommc.modularui.network.NetworkUtils;
-import com.cleanroommc.modularui.screen.ClientScreenHandler;
 import com.cleanroommc.modularui.screen.ModularContainer;
 import com.cleanroommc.modularui.widgets.slot.SlotGroup;
 import com.cleanroommc.bogosorter.api.ISortingContextBuilder;
@@ -63,9 +61,7 @@ public void detectAndSendChanges(boolean init) {
     }
 
     public void onClose() {
-        if (NetworkUtils.isClient() && ClientScreenHandler.guiIsClosing) {
-            this.panelSyncManagerMap.values().forEach(PanelSyncManager::onClose);
-        }
+        this.panelSyncManagerMap.values().forEach(PanelSyncManager::onClose);
     }
 
     public void onOpen() {

src/main/java/com/cleanroommc/modularui/value/sync/PanelSyncManager.java

@@ -23,7 +23,11 @@
 import org.jetbrains.annotations.NotNull;
 
 import java.io.IOException;
-import java.util.*;
+import java.util.ArrayList;
+import java.util.Collection;
+import java.util.List;
+import java.util.Map;
+import java.util.Objects;
 import java.util.function.Consumer;
 import java.util.function.Supplier;
 
@@ -90,10 +94,8 @@ public void onOpen() {
     @ApiStatus.Internal
     public void onClose() {
         this.closeListener.forEach(listener -> listener.accept(getPlayer()));
-        for (String name : this.subPanels.keySet()) {
-            SyncHandler sh = this.getModularSyncManager().getMainPSM().syncHandlers.remove(name);
-            this.getModularSyncManager().getMainPSM().reverseSyncHandlers.remove(sh);
-        }
+        // previously panel sync handlers were removed from the main psm, however this problematic if the screen will be reopened at some
+        // we can just not remove the sync handlers since mui has proper checks for re-registering panels
     }
 
     public boolean isInitialised() {