more readable panel sync handler syncing

Author: brachy84

src/main/java/com/cleanroommc/modularui/value/sync/PanelSyncHandler.java

@@ -21,6 +21,11 @@
  */
 public final class PanelSyncHandler extends SyncHandler implements IPanelHandler {
 
+    public static final int SYNC_NOTIFY_OPEN = 0;
+    public static final int SYNC_OPEN = 1;
+    public static final int SYNC_CLOSE = 2;
+    public static final int SYNC_DISPOSE = 3;
+
     private final IPanelBuilder panelBuilder;
     private final boolean subPanel;
     private String panelName;
@@ -51,7 +56,7 @@ private void openPanel(boolean syncToServer) {
         if (isPanelOpen()) return;
         boolean client = getSyncManager().isClient();
         if (syncToServer && client) {
-            syncToServer(0);
+            syncToServer(SYNC_NOTIFY_OPEN);
             return;
         }
         if (this.syncManager != null && this.syncManager.getModularSyncManager() != getSyncManager().getModularSyncManager()) {
@@ -94,7 +99,7 @@ public void closePanel() {
                 this.openedPanel.closeIfOpen();
             }
         } else {
-            syncToClient(2);
+            syncToClient(SYNC_CLOSE);
         }
     }
 
@@ -109,15 +114,14 @@ public void closePanelInternal() {
         getSyncManager().getModularSyncManager().close(this.panelName);
         this.open = false;
         if (getSyncManager().isClient()) {
-            syncToServer(2);
+            syncToServer(SYNC_CLOSE);
         }
     }
 
     @Override
     public void deleteCachedPanel() {
         if (openedPanel == null || isPanelOpen()) return;
         boolean canDispose = WidgetTree.foreachChild(openedPanel, iWidget -> {
-            if (!iWidget.isValid()) return false;
             if (iWidget instanceof ISynced<?> synced && synced.isSynced()) {
                 return !(synced.getSyncHandler() instanceof ItemSlotSH);
             }
@@ -126,12 +130,12 @@ public void deleteCachedPanel() {
 
         // This is because we can't guarantee that the sync handlers of the new panel are the same.
         // Dynamic sync handler changing is very error-prone.
-        if (!canDispose)
+        if (!canDispose) {
             throw new UnsupportedOperationException("Can't delete cached panel if it's still open or has ItemSlot Sync Handlers!");
+        }
 
         disposePanel();
-
-        sync(3);
+        sync(SYNC_DISPOSE);
     }
 
     private void disposePanel() {
@@ -152,23 +156,23 @@ public boolean isPanelOpen() {
 
     @Override
     public void readOnClient(int i, PacketBuffer packetBuffer) throws IOException {
-        if (i == 1) {
+        if (i == SYNC_OPEN) {
             openPanel(false);
-        } else if (i == 2) {
+        } else if (i == SYNC_CLOSE) {
             closePanel();
-        } else if (i == 3) {
+        } else if (i == SYNC_DISPOSE) {
             disposePanel();
         }
     }
 
     @Override
     public void readOnServer(int i, PacketBuffer packetBuffer) throws IOException {
-        if (i == 0) {
+        if (i == SYNC_NOTIFY_OPEN) {
             openPanel(false);
-            syncToClient(1);
-        } else if (i == 2) {
+            syncToClient(SYNC_OPEN);
+        } else if (i == SYNC_CLOSE) {
             closePanelInternal();
-        } else if (i == 3) {
+        } else if (i == SYNC_DISPOSE) {
             disposePanel();
         }
     }