properly fix sync issue

Author: brachy84

src/main/java/com/cleanroommc/modularui/factory/GuiManager.java

@@ -66,17 +66,17 @@ public static <T extends GuiData> void open(@NotNull UIFactory<T> factory, @NotN
         ModularPanel panel = factory.createPanel(guiData, syncManager);
         WidgetTree.collectSyncValues(syncManager, panel);
         ModularContainer container = new ModularContainer(syncManager);
-        // open container // this mimics forge behaviour
+        // sync to client
         player.getNextWindowId();
         player.closeContainer();
         int windowId = player.currentWindowId;
-        player.openContainer = container;
-        player.openContainer.windowId = windowId;
-        player.openContainer.addListener(player);
-        // sync to client
         PacketBuffer buffer = new PacketBuffer(Unpooled.buffer());
         factory.writeGuiData(guiData, buffer);
         NetworkHandler.sendToPlayer(new OpenGuiPacket<>(windowId, factory, buffer), player);
+        // open container // this mimics forge behaviour
+        player.openContainer = container;
+        player.openContainer.windowId = windowId;
+        player.openContainer.addListener(player);
         // finally invoke event
         MinecraftForge.EVENT_BUS.post(new PlayerContainerEvent.Open(player, container));
     }

src/main/java/com/cleanroommc/modularui/network/NetworkHandler.java

@@ -25,7 +25,7 @@ public static void init() {
         registerC2S(PacketSyncHandler.class);
         registerC2S(SyncConfig.class);
         registerS2C(OpenGuiPacket.class);
-        registerC2S(OpenGuiHandshake.class);
+        //registerC2S(OpenGuiHandshake.class);
     }
 
     private static void registerC2S(Class<? extends IPacket> clazz) {

src/main/java/com/cleanroommc/modularui/network/packets/OpenGuiHandshake.java

@@ -50,7 +50,6 @@ public void read(PacketBuffer buf) {
     @Override
     public @Nullable IPacket executeClient(NetHandlerPlayClient handler) {
         GuiManager.open(this.windowId, this.factory, this.data, Minecraft.getMinecraft().player);
-        NetworkHandler.sendToServer(new OpenGuiHandshake(this.windowId));
         return null;
     }
 }

src/main/java/com/cleanroommc/modularui/network/packets/OpenGuiPacket.java

@@ -46,7 +46,7 @@ public static ModularContainer getCurrent(EntityPlayer player) {
     }
 
     private final GuiSyncManager guiSyncManager;
-    private boolean init = true, handshake = false;
+    private boolean init = true;
     private final List<ModularSlot> slots = new ArrayList<>();
     private final List<ModularSlot> shiftClickSlots = new ArrayList<>();
 
@@ -72,17 +72,14 @@ public ContainerAccessor acc() {
     @Override
     public void onContainerClosed(@NotNull EntityPlayer playerIn) {
         super.onContainerClosed(playerIn);
-        this.handshake = false;
         if (this.guiSyncManager != null) {
             this.guiSyncManager.onClose();
         }
     }
 
     @Override
     public void detectAndSendChanges() {
-        if (this.handshake) {
-            super.detectAndSendChanges();
-        }
+        super.detectAndSendChanges();
         this.guiSyncManager.detectAndSendChanges(this.init);
         this.init = false;
     }
@@ -366,8 +363,4 @@ public void buildSortingContext(ISortingContextBuilder builder) {
     public IPosSetter getPlayerButtonPosSetter() {
         return null;
     }
-
-    public void onHandshake() {
-        this.handshake = true;
-    }
 }