Skip to content

Commit 9bd4b54

Browse files
author
Clément Pinard
committed
make dataset split value more robust
1 parent 02d58e0 commit 9bd4b54

File tree

2 files changed

+10
-4
lines changed

2 files changed

+10
-4
lines changed

datasets/util.py

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,10 +6,15 @@ def split2list(images, split, default_split=0.9):
66
with open(split) as f:
77
split_values = [x.strip() == '1' for x in f.readlines()]
88
assert(len(images) == len(split_values))
9-
elif isinstance(split, float):
10-
split_values = np.random.uniform(0,1,len(images)) < split
11-
else:
9+
elif split is None:
1210
split_values = np.random.uniform(0,1,len(images)) < default_split
11+
else:
12+
try:
13+
split = float(split)
14+
except TypeError:
15+
print("Invalid Split value, it must be either a filepath or a float")
16+
raise
17+
split_values = np.random.uniform(0,1,len(images)) < split
1318
train_samples = [sample for sample, split in zip(images, split_values) if split]
1419
test_samples = [sample for sample, split in zip(images, split_values) if not split]
1520
return train_samples, test_samples

main.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,8 @@
3333
group.add_argument('-s', '--split-file', default=None, type=str,
3434
help='test-val split file')
3535
group.add_argument('--split-value', default=0.8, type=float,
36-
help='test-val split proportion (between 0 (only test) and 1 (only train))')
36+
help='test-val split proportion between 0 (only test) and 1 (only train), '
37+
'will be overwritten if a split file is set')
3738
parser.add_argument('--arch', '-a', metavar='ARCH', default='flownets',
3839
choices=model_names,
3940
help='model architecture, overwritten if pretrained is specified: ' +

0 commit comments

Comments
 (0)