some notes

Author: ClementTsang

src/data_collection/disks/unix/macos/counters.rs

@@ -6,7 +6,7 @@ use crate::data_collection::disks::IoCounters;
 fn get_device_io(device: io_kit::IoObject) -> anyhow::Result<IoCounters> {
     let parent = device.service_parent()?;
 
-    // XXX: Re: Conform check being disabled.
+    // NB: Regarding the conform check being disabled.
     //
     // Okay, so this is weird.
     //

src/new_data_collection/sources/sysinfo/disk.rs

@@ -0,0 +1 @@
+

src/new_data_collection/sources/sysinfo/mod.rs

@@ -1,4 +1,4 @@
-pub mod temperature;
 pub mod cpu;
 pub mod disk;
-pub mod memory;
+pub mod memory;
+pub mod temperature;

src/utils/logging.rs

@@ -18,7 +18,7 @@ pub fn init_logger(
                 // logging at all in a debug context which is generally fine,
                 // release builds should have this logging disabled entirely for now.
                 unsafe {
-                    // XXX: If we ever DO add general logging as a release feature, evaluate this
+                    // NB: If we ever DO add general logging as a release feature, evaluate this
                     // again and whether this is something we want enabled in
                     // release builds! What might be safe is falling back to the non-set-soundness
                     // mode when specifically using certain feature flags (e.g. dev-logging feature