refactor: use getDevHubUrl & getDocUrl helpers

- Replace all occurrences of `generateDocsHref` with `getDocUrl`,
- Replace all occurrences of `generateDevHubHref` with `getDevHubUrl`,
- Change import paths from `utils.js` to `dev-hub-url.js`,
- Remove all trailing slashes.

Fixes #1579

Author: florian-sanders-cc

.storybook/manager.js

@@ -2,7 +2,7 @@
 import { addons } from 'storybook/manager-api';
 // eslint-disable-next-line import-x/extensions
 import { create } from 'storybook/theming';
-import { generateDocsHref } from '../src/lib/utils.js';
+import { getDocUrl } from '../src/lib/dev-hub-url.js';
 import { enhanceStoryName } from '../src/stories/lib/story-names.js';
 
 // We could create an addon to provide a control that would switch between dark / light
@@ -12,7 +12,7 @@ const isDarkMode = window.matchMedia('(prefers-color-scheme: dark)').matches;
 const cleverTheme = create({
   base: isDarkMode ? 'dark' : 'light',
   brandTitle: 'Clever Cloud components',
-  brandUrl: generateDocsHref(),
+  brandUrl: getDocUrl(),
   brandImage: isDarkMode ? 'imgs/logo-clever-dark.svg' : 'imgs/logo-clever-light.svg',
 });
 

src/components/cc-addon-credentials-beta/cc-addon-credentials-beta.smart-keycloak.js

@@ -1,6 +1,6 @@
+import { getDocUrl } from '../../lib/dev-hub-url.js';
 import { notifyError, notifySuccess } from '../../lib/notifications.js';
 import { defineSmartComponent } from '../../lib/smart/define-smart-component.js';
-import { generateDocsHref } from '../../lib/utils.js';
 import { i18n } from '../../translations/translation.js';
 import '../cc-smart-container/cc-smart-container.js';
 import { CcAddonCredentialsBetaClient } from './cc-addon-credentials-beta.client.js';
@@ -30,7 +30,7 @@ const LOADING_STATE = {
       ],
       docLink: {
         text: i18n('cc-addon-credentials-beta.doc-link.keycloak'),
-        href: generateDocsHref('/addons/keycloak/#secured-multi-instances'),
+        href: getDocUrl('/addons/keycloak/#secured-multi-instances'),
       },
     },
   },

src/components/cc-addon-credentials-beta/cc-addon-credentials-beta.smart-otoroshi.js

@@ -1,7 +1,7 @@
+import { getDocUrl } from '../../lib/dev-hub-url.js';
 import { fakeString } from '../../lib/fake-strings.js';
 import { notifyError, notifySuccess } from '../../lib/notifications.js';
 import { defineSmartComponent } from '../../lib/smart/define-smart-component.js';
-import { generateDocsHref } from '../../lib/utils.js';
 import { i18n } from '../../translations/translation.js';
 import '../cc-smart-container/cc-smart-container.js';
 import { CcAddonCredentialsBetaClient } from './cc-addon-credentials-beta.client.js';
@@ -29,7 +29,7 @@ const LOADING_STATE = {
       ],
       docLink: {
         text: i18n('cc-addon-credentials-beta.doc-link.otoroshi-ng'),
-        href: generateDocsHref('/addons/otoroshi/#use-otoroshi-in-a-network-group'),
+        href: getDocUrl('/addons/otoroshi/#use-otoroshi-in-a-network-group'),
       },
     },
     api: {
@@ -58,7 +58,7 @@ const LOADING_STATE = {
       ],
       docLink: {
         text: i18n('cc-addon-credentials-beta.doc-link.otoroshi-api'),
-        href: generateDocsHref('/addons/otoroshi/#manage-otoroshi-from-its-api'),
+        href: getDocUrl('/addons/otoroshi/#manage-otoroshi-from-its-api'),
       },
     },
   },

src/components/cc-addon-header/cc-addon-header.smart-keycloak.js

@@ -1,13 +1,13 @@
+import { getDocUrl } from '../../lib/dev-hub-url.js';
 import { fakeString } from '../../lib/fake-strings.js';
 import { notify, notifyError } from '../../lib/notifications.js';
 import { defineSmartComponent } from '../../lib/smart/define-smart-component.js';
-import { generateDocsHref } from '../../lib/utils.js';
 import { i18n } from '../../translations/translation.js';
 import '../cc-smart-container/cc-smart-container.js';
 import { CcAddonHeaderClient } from './cc-addon-header.client.js';
 import './cc-addon-header.js';
 
-const DOCS_URL = generateDocsHref(`/addons/keycloak`);
+const DOCS_URL = getDocUrl(`/addons/keycloak`);
 const PROVIDER_ID = 'keycloak';
 
 /**

src/components/cc-addon-header/cc-addon-header.smart-matomo.js

@@ -1,13 +1,13 @@
+import { getDocUrl } from '../../lib/dev-hub-url.js';
 import { fakeString } from '../../lib/fake-strings.js';
 import { notify, notifyError } from '../../lib/notifications.js';
 import { defineSmartComponent } from '../../lib/smart/define-smart-component.js';
-import { generateDocsHref } from '../../lib/utils.js';
 import { i18n } from '../../translations/translation.js';
 import '../cc-smart-container/cc-smart-container.js';
 import { CcAddonHeaderClient } from './cc-addon-header.client.js';
 import './cc-addon-header.js';
 
-const DOCS_URL = generateDocsHref(`/addons/matomo`);
+const DOCS_URL = getDocUrl(`/addons/matomo`);
 const PROVIDER_ID = 'matomo';
 
 /**

src/components/cc-addon-header/cc-addon-header.smart-metabase.js

@@ -1,13 +1,13 @@
+import { getDocUrl } from '../../lib/dev-hub-url.js';
 import { fakeString } from '../../lib/fake-strings.js';
 import { notify, notifyError } from '../../lib/notifications.js';
 import { defineSmartComponent } from '../../lib/smart/define-smart-component.js';
-import { generateDocsHref } from '../../lib/utils.js';
 import { i18n } from '../../translations/translation.js';
 import '../cc-smart-container/cc-smart-container.js';
 import { CcAddonHeaderClient } from './cc-addon-header.client.js';
 import './cc-addon-header.js';
 
-const DOCS_URL = generateDocsHref(`/addons/metabase`);
+const DOCS_URL = getDocUrl(`/addons/metabase`);
 const PROVIDER_ID = 'metabase';
 
 /**

src/components/cc-addon-header/cc-addon-header.smart-otoroshi.js

@@ -1,13 +1,13 @@
+import { getDocUrl } from '../../lib/dev-hub-url.js';
 import { fakeString } from '../../lib/fake-strings.js';
 import { notify, notifyError } from '../../lib/notifications.js';
 import { defineSmartComponent } from '../../lib/smart/define-smart-component.js';
-import { generateDocsHref } from '../../lib/utils.js';
 import { i18n } from '../../translations/translation.js';
 import '../cc-smart-container/cc-smart-container.js';
 import { CcAddonHeaderClient } from './cc-addon-header.client.js';
 import './cc-addon-header.js';
 
-const DOCS_URL = generateDocsHref(`/addons/otoroshi`);
+const DOCS_URL = getDocUrl(`/addons/otoroshi`);
 const PROVIDER_ID = 'otoroshi';
 
 /**

src/components/cc-addon-info/cc-addon-info.client.js

@@ -4,8 +4,8 @@ import { get as getAddon } from '@clevercloud/client/esm/api/v2/addon.js';
 import { getGrafanaOrganisation } from '@clevercloud/client/esm/api/v4/saas.js';
 // @ts-expect-error FIXME: remove when clever-client exports types
 import { ONE_SECOND } from '@clevercloud/client/esm/with-cache.js';
+import { getDevHubUrl } from '../../lib/dev-hub-url.js';
 import { sendToApi } from '../../lib/send-to-api.js';
-import { generateDevHubHref } from '../../lib/utils.js';
 
 /**
  * @typedef {import('./cc-addon-info.types.js').AddonInfoStateLoaded} AddonInfoStateLoaded
@@ -178,7 +178,7 @@ export function formatVersionState(operatorVersionInfo) {
       installed: operatorVersionInfo.installed,
       available: operatorVersionInfo.available.filter((version) => version !== operatorVersionInfo.installed),
       latest: operatorVersionInfo.latest,
-      changelogLink: `${generateDevHubHref('/changelog')}`,
+      changelogLink: `${getDevHubUrl('/changelog')}`,
     };
   }
 

src/components/cc-addon-info/cc-addon-info.smart-keycloak.js

@@ -1,7 +1,7 @@
 import { getAssetUrl } from '../../lib/assets-url.js';
+import { getDocUrl } from '../../lib/dev-hub-url.js';
 import { notifyError, notifySuccess } from '../../lib/notifications.js';
 import { defineSmartComponent } from '../../lib/smart/define-smart-component.js';
-import { generateDocsHref } from '../../lib/utils.js';
 import { i18n } from '../../translations/translation.js';
 import '../cc-smart-container/cc-smart-container.js';
 import { CcAddonInfoClient, formatVersionState } from './cc-addon-info.client.js';
@@ -72,7 +72,7 @@ defineSmartComponent({
     updateComponent('state', LOADING_STATE);
     updateComponent('docLink', {
       text: i18n('cc-addon-info.doc-link.keycloak'),
-      href: generateDocsHref('/addons/keycloak'),
+      href: getDocUrl('/addons/keycloak'),
     });
 
     api

src/components/cc-addon-info/cc-addon-info.smart-matomo.js

@@ -1,7 +1,7 @@
 import { getAssetUrl } from '../../lib/assets-url.js';
+import { getDocUrl } from '../../lib/dev-hub-url.js';
 import { sendToApi } from '../../lib/send-to-api.js';
 import { defineSmartComponent } from '../../lib/smart/define-smart-component.js';
-import { generateDocsHref } from '../../lib/utils.js';
 import { i18n } from '../../translations/translation.js';
 import '../cc-smart-container/cc-smart-container.js';
 import { CcAddonInfoClient } from './cc-addon-info.client.js';
@@ -87,7 +87,7 @@ defineSmartComponent({
     updateComponent('state', LOADING_STATE);
     updateComponent('docLink', {
       text: i18n('cc-addon-info.doc-link.matomo'),
-      href: generateDocsHref('/addons/matomo'),
+      href: getDocUrl('/addons/matomo'),
     });
 
     api