Skip to content

Conversation

@HeleneAmouzou
Copy link
Contributor

@HeleneAmouzou HeleneAmouzou commented Oct 23, 2025

What does this PR do?

  • Adds Kubernetes dashboard to index.html,
  • Declines cc-addon-header and cc-addon-info for Kubernetes product.

How to review?

  • Check the commits,
  • Check the code,
  • Play with demo-smart.

@github-actions
Copy link
Contributor

🔎 A preview has been automatically published : https://clever-components-preview.cellar-c2.services.clever-cloud.com/dashboard-addons/kube/index.html.

This preview will be deleted once this PR is closed.

@florian-sanders-cc florian-sanders-cc changed the title feat(cc-addon-header.smart-kubernetes): init feat(cc-addon-*.smart-kubernetes): init Oct 27, 2025
Copy link
Member

@roberttran-cc roberttran-cc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice adaptations, good job! A few non-blocking feedback for me (aka the janitor). 🧹

Copy link
Contributor

@pdesoyres-cc pdesoyres-cc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done Hélène. I left few questions and comments

@HeleneAmouzou HeleneAmouzou force-pushed the dashboard-addons/kube branch 2 times, most recently from eb031ff to b64bcb3 Compare October 28, 2025 16:33
@florian-sanders-cc florian-sanders-cc force-pushed the dashboard-addons/kube branch 2 times, most recently from d378900 to 530a10c Compare October 29, 2025 12:17
@florian-sanders-cc florian-sanders-cc dismissed pdesoyres-cc’s stale review October 30, 2025 14:15

Feedback has been processed by Hélène 👍

@florian-sanders-cc florian-sanders-cc merged commit b757dee into master Oct 30, 2025
10 checks passed
@florian-sanders-cc florian-sanders-cc deleted the dashboard-addons/kube branch October 30, 2025 14:15
@github-actions
Copy link
Contributor

🔎 The preview has been automatically deleted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants