fixed some warning and improved code

Author: naseif

Source/VisualPairCoding/VisualPairCoding.AvaloniaUI/EnterNamesWindow.axaml.cs

@@ -32,7 +32,7 @@ private void OnActivated(object? sender, EventArgs e)
             if (_autostart)
             {
                 RoutedEventArgs? args = e as RoutedEventArgs;
-                this.StartForm(sender, args);
+                this.StartForm(sender, args!);
             }
         }
 
@@ -68,7 +68,7 @@ public async void StartForm(object? sender, RoutedEventArgs args)
                 sessionForm.Hide();
 
                 var tcs = new TaskCompletionSource<object>();
-                sessionForm.Closed += (s, e) => tcs.SetResult(null);
+                sessionForm.Closed += (s, e) => tcs.SetResult(null!);
                 sessionForm.Show();
                 await tcs.Task;
             }
@@ -154,7 +154,7 @@ private void RandomizeParticipants(object? sender, RoutedEventArgs args)
         }
 
 
-        private static Random random = new();
+        private static readonly Random random = new();
 
         public static void Shuffle<T>(IList<T> list)
         {
@@ -163,9 +163,7 @@ public static void Shuffle<T>(IList<T> list)
             {
                 n--;
                 int k = random.Next(n + 1);
-                T value = list[k];
-                list[k] = list[n];
-                list[n] = value;
+                (list[n], list[k]) = (list[k], list[n]);
             }
         }
 
@@ -194,7 +192,7 @@ private List<string> GetParticipants()
 
         public async void LoadSessionConfiguration(object? sender, RoutedEventArgs args)
         {
-            OpenFileDialog openFileDialog = new OpenFileDialog
+            OpenFileDialog openFileDialog = new()
             {
                 Title = "Open VPC Session",
                 Filters = new List<FileDialogFilter>
@@ -226,7 +224,7 @@ public async void SaveSessionConfiguration(object? sender, RoutedEventArgs args)
             var participants = GetParticipants();
 
 
-            SaveFileDialog saveFileDialog = new SaveFileDialog();
+            SaveFileDialog saveFileDialog = new();
             saveFileDialog.Filters?.Add(new FileDialogFilter { Name = "VPC Session", Extensions = { "vpcsession" } });
             saveFileDialog.InitialFileName = string.Join("_", participants);
 

Source/VisualPairCoding/VisualPairCoding.AvaloniaUI/RunSessionForm.axaml.cs

@@ -133,7 +133,7 @@ private async void ChooseAnotherPairAndStartNewTurn()
                 );
 
             var tcs = new TaskCompletionSource<object>();
-            form.Closed += (s, e) => tcs.SetResult(null);
+            form.Closed += (s, e) => tcs.SetResult(null!);
 
             form.Show();
             form.Topmost = true;

Source/VisualPairCoding/VisualPairCoding.Infrastructure/AutoUpdater.cs

@@ -23,27 +23,25 @@ public AutoUpdater(
 
     public GithubAPIResponse[] GetReleaseList() 
     {
-        using (var client = new HttpClient())
-        {
-            var webRequest = new HttpRequestMessage(HttpMethod.Get, _githubUrl);
-            client.DefaultRequestHeaders.Add("User-Agent", "Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:103.0) Gecko/20100101 Firefox/103.0");
+        using var client = new HttpClient();
+        var webRequest = new HttpRequestMessage(HttpMethod.Get, _githubUrl);
+        client.DefaultRequestHeaders.Add("User-Agent", "Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:103.0) Gecko/20100101 Firefox/103.0");
 
-            var response = client.Send(webRequest);
+        var response = client.Send(webRequest);
 
-            string result = response.Content.ReadAsStringAsync().Result.Trim();
+        string result = response.Content.ReadAsStringAsync().Result.Trim();
 
-            GithubAPIResponse[] releases = JsonConvert.DeserializeObject<GithubAPIResponse[]>(result);
+        GithubAPIResponse[] releases = JsonConvert.DeserializeObject<GithubAPIResponse[]>(result)!;
 
-            return releases;
-        }
+        return releases!;
     }
 
 
     public void Update()
     {
         GithubAPIResponse[] releases = GetReleaseList();
 
-        using (WebClient downloadClient = new WebClient())
+        using (WebClient downloadClient = new())
         {
             downloadClient.DownloadFile(releases[0].Assets[0].Browser_download_url, releases[0].Assets[0].Name);
         }