fixed warnings about NULL

Author: stho32

Source/VisualPairCoding/VisualPairCoding.AvaloniaUI/EnterNamesWindow.axaml.cs

@@ -34,9 +34,9 @@ public EnterNamesForm(bool autostart, string configPath)
             }
         }
 
-        private MenuItem? GetRecentMenuItem()
+        private MenuItem GetRecentMenuItem()
         {
-            return this.FindControl<MenuItem>("recentMenuItem");
+            return this.FindControl<MenuItem>("recentMenuItem")!;
         }
 
         private TimeSpan GetSessionTotalDuration()
@@ -131,7 +131,7 @@ public async void StartForm(object? sender, RoutedEventArgs args)
         {
             var participants = GetParticipants();
             var totalDuration = GetSessionTotalDuration();
-            var session = new PairCodingSession(participants, (int)minutesPerTurn.Value, GetSessionTotalDuration());
+            var session = new PairCodingSession(participants, (int)minutesPerTurn.Value!, GetSessionTotalDuration());
             var validationMessage = session.Validate();
 
             if (!string.IsNullOrWhiteSpace(validationMessage))
@@ -259,16 +259,16 @@ private static void AddParticipantIfAvailable(string name, List<string> particip
         private string[] GetParticipants()
         {
             var participants = new List<string>();
-            AddParticipantIfAvailable(participant1.Text, participants);
-            AddParticipantIfAvailable(participant2.Text, participants);
-            AddParticipantIfAvailable(participant3.Text, participants);
-            AddParticipantIfAvailable(participant4.Text, participants);
-            AddParticipantIfAvailable(participant5.Text, participants);
-            AddParticipantIfAvailable(participant6.Text, participants);
-            AddParticipantIfAvailable(participant7.Text, participants);
-            AddParticipantIfAvailable(participant8.Text, participants);
-            AddParticipantIfAvailable(participant9.Text, participants);
-            AddParticipantIfAvailable(participant10.Text, participants);
+            AddParticipantIfAvailable(participant2.Text ?? string.Empty, participants);
+            AddParticipantIfAvailable(participant1.Text ?? string.Empty, participants);
+            AddParticipantIfAvailable(participant3.Text ?? string.Empty, participants);
+            AddParticipantIfAvailable(participant4.Text ?? string.Empty, participants);
+            AddParticipantIfAvailable(participant5.Text ?? string.Empty, participants);
+            AddParticipantIfAvailable(participant6.Text ?? string.Empty, participants);
+            AddParticipantIfAvailable(participant7.Text ?? string.Empty, participants);
+            AddParticipantIfAvailable(participant8.Text ?? string.Empty, participants);
+            AddParticipantIfAvailable(participant9.Text ?? string.Empty, participants);
+            AddParticipantIfAvailable(participant10.Text ?? string.Empty, participants);
 
             return participants.ToArray();
         }

Source/VisualPairCoding/VisualPairCoding.AvaloniaUI/RunSessionForm.axaml.cs

@@ -12,14 +12,15 @@ namespace VisualPairCoding.AvaloniaUI
 {
     public partial class RunSessionForm : Window
     {
-        private readonly PairCodingSession _pairCodingSession;
+        private readonly PairCodingSession? _pairCodingSession;
         private TimeSpan _currentTime = TimeSpan.Zero;
         private TimeSpan _totalDuration;
         private int _currentParticipant = -1;
         private readonly Random random = new();
-        private readonly DispatcherTimer timer;
+        private readonly DispatcherTimer? timer;
         private readonly bool _explicitlyConfirmTurnChange = true;
         private bool _totalDurationActivated;
+
         public RunSessionForm()
         {
             InitializeComponent();
@@ -87,7 +88,7 @@ private void OnPointerLeave(object? sender, PointerEventArgs e)
 
         private void CloseForm(object sender, RoutedEventArgs args)
         {
-            timer.IsEnabled = false;
+            timer!.IsEnabled = false;
             timer.Stop();
             Close();
         }
@@ -96,7 +97,7 @@ private async void Timer_Tick(object? sender, EventArgs e)
         {
             if (_totalDuration <= TimeSpan.Zero && _totalDurationActivated)
             {
-                timer.IsEnabled = false;
+                timer!.IsEnabled = false;
                 var totalForm = new NewTurnForm(
                 "Total Duration Exceeded!",
                 _explicitlyConfirmTurnChange
@@ -129,9 +130,9 @@ private async void Timer_Tick(object? sender, EventArgs e)
 
         private async void ChooseAnotherPairAndStartNewTurn()
         {
-            timer.Stop();
+            timer!.Stop();
 
-            _currentTime = new TimeSpan(0, _pairCodingSession.MinutesPerTurn, 0);
+            _currentTime = new TimeSpan(0, _pairCodingSession!.MinutesPerTurn, 0);
 
             _currentParticipant += 1;
             if (_currentParticipant >= _pairCodingSession.Participants.Length)
@@ -175,7 +176,7 @@ private static string GetRandomNavigatorFromListWithout(string currentlyActivePa
 
         private void PauseButton_Click(object? sender, RoutedEventArgs args)
         {
-            if (timer.IsEnabled)
+            if (timer!.IsEnabled)
             {
                 PauseButton.Content = "PAUSED";
                 timer.Stop();
@@ -191,7 +192,7 @@ private void SkipCurrentDriverButton_Click(object? sender, RoutedEventArgs args)
         {
             Topmost = false;
             ChooseAnotherPairAndStartNewTurn();
-            activeParticipnat.Text = _pairCodingSession.Participants[_currentParticipant];
+            activeParticipnat.Text = _pairCodingSession!.Participants[_currentParticipant];
 
             remainingTimeLabel.Text = _currentTime.ToString();