Define and use all_specific_gs

Author: charleskawczynski

src/prognostic_equations/hyperdiffusion.jl

@@ -242,11 +242,10 @@ NVTX.@annotate function prep_tracer_hyperdiffusion_tendency!(Yₜ, Y, p, t)
 
     (; ᶜ∇²specific_tracers) = p.hyperdiff
 
-    for ρχ_name in filter(is_tracer_var, propertynames(Y.c))
-        χ_name = specific_name(ρχ_name)
-        ᶜρχ = getproperty(Y.c, ρχ_name)
-        ᶜχ = @. lazy(specific(ᶜρχ, Y.c.ρ))
-        @. ᶜ∇²specific_tracers.:($$χ_name) = wdivₕ(gradₕ(ᶜχ))
+    ᶜspecific = all_specific_gs(Y.c)
+
+    for χ_name in propertynames(ᶜ∇²specific_tracers)
+        @. ᶜ∇²specific_tracers.:($$χ_name) = wdivₕ(gradₕ(ᶜspecific.:($$χ_name)))
     end
 
     if turbconv_model isa PrognosticEDMFX

src/utils/variable_manipulations.jl

@@ -182,6 +182,32 @@ omitted from the result.
     return :(NamedTuple{$specific_gs_names}(($(specific_gs_values...),)))
 end
 
+"""
+    all_specific_gs(gs)
+
+Lazily computes all specific quantities (`χ`) from a grid-scale state `gs`.
+This `@generated` function introspects the field names of `gs` at compile time.
+It identifies all density-weighted fields (e.g., `:ρq_tot`, `:ρe_tot`), divides
+them by the grid-scale density `gs.ρ`, and returns them in a new `NamedTuple`.
+This provides a type-stable and performant way to convert all relevant state
+variables to their specific counterparts at once.
+
+Arguments:
+- `gs`: The grid-scale state, which must contain a `:ρ` field and other fields
+    with a `:ρ` prefix.
+
+Returns:
+- A new `NamedTuple` containing only the specific quantities (e.g., `:q_tot`, `:e_tot`).
+"""
+@generated function all_specific_gs(gs)
+    gs_names = Base._nt_names(gs)
+    relevant_gs_names =
+        filter(name -> has_prefix(name, :ρ) && name != :ρ, gs_names)
+    all_specific_gs_names = map(name -> remove_prefix(name, :ρ), relevant_gs_names)
+    all_specific_gs_values = map(name -> :(lazy.(specific.(gs.$name, gs.ρ))), relevant_gs_names)
+    return :(NamedTuple{$all_specific_gs_names}(($(all_specific_gs_values...),)))
+end
+
 """
     specific_sgs(sgs, gs, turbconv_model)