fix a bug in edmf diffusion

Author: szy21

reproducibility_tests/ref_counter.jl

@@ -1,4 +1,4 @@
-255
+256
 
 # **README**
 #
@@ -20,6 +20,9 @@
 
 
 #=
+256
+- Fix a bug in EDMF diffusive flux
+
 255
 - Add radiation tendency to prognostic edmf updrafts
 

src/cache/temporary_quantities.jl

@@ -11,7 +11,8 @@ function implicit_temporary_quantities(Y, atmos)
     FT = Spaces.undertype(center_space)
     uvw_vec = UVW(FT(0), FT(0), FT(0))
     return (;
-        ᶠtemp_scalar = Fields.Field(FT, face_space), # ᶠρaK_h, ᶠρaK_u
+        ᶠtemp_scalar = Fields.Field(FT, face_space), # ᶠρaK_h
+        ᶠtemp_scalar_2 = Fields.Field(FT, face_space), # ᶠρaK_u
         ᶜtemp_scalar = Fields.Field(FT, center_space), # ᶜρχₜ_diffusion, ᶜa_scalar
         ᶜtemp_scalar_2 = Fields.Field(FT, center_space), # ᶜKᵥʲ
         ᶜtemp_scalar_3 = Fields.Field(FT, center_space), # ᶜK_h_scaled
@@ -27,7 +28,8 @@ function temporary_quantities(Y, atmos)
     CTh = CTh_vector_type(Y.c)
     uvw_vec = UVW(FT(0), FT(0), FT(0))
     return (;
-        ᶠtemp_scalar = Fields.Field(FT, face_space), # ᶠp, ᶠρK_E
+        ᶠtemp_scalar = Fields.Field(FT, face_space), # ᶠp, ᶠρK_h
+        ᶠtemp_scalar_2 = Fields.Field(FT, face_space), # ᶠρK_u
         ᶜtemp_scalar = Fields.Field(FT, center_space), # ᶜ1
         ᶜtemp_scalar_2 = Fields.Field(FT, center_space), # ᶜtke_exch
         ᶜtemp_scalar_3 = Fields.Field(FT, center_space),

src/prognostic_equations/edmfx_sgs_flux.jl

@@ -369,7 +369,7 @@ function edmfx_sgs_diffusive_flux_tendency!(
         ᶜK_h = @. lazy(eddy_diffusivity(ᶜK_u, ᶜprandtl_nvec))
         ᶠρaK_h = p.scratch.ᶠtemp_scalar
         @. ᶠρaK_h = ᶠinterp(ᶜρa⁰) * ᶠinterp(ᶜK_h)
-        ᶠρaK_u = p.scratch.ᶠtemp_scalar
+        ᶠρaK_u = p.scratch.ᶠtemp_scalar_2
         @. ᶠρaK_u = ᶠinterp(ᶜρa⁰) * ᶠinterp(ᶜK_u)
 
         # Total enthalpy diffusion
@@ -497,7 +497,7 @@ function edmfx_sgs_diffusive_flux_tendency!(
 
         ᶠρaK_h = p.scratch.ᶠtemp_scalar
         @. ᶠρaK_h = ᶠinterp(Y.c.ρ) * ᶠinterp(ᶜK_h)
-        ᶠρaK_u = p.scratch.ᶠtemp_scalar
+        ᶠρaK_u = p.scratch.ᶠtemp_scalar_2
         @. ᶠρaK_u = ᶠinterp(Y.c.ρ) * ᶠinterp(ᶜK_u)
 
         # Total enthalpy diffusion