Skip to content

Commit afe6f3e

Browse files
committed
Unconditionally update insolation tuple
I am not sure why insolation was set to not be updated with `CouplerAlbedo`, but I don't think this is currently necessary. The function `set_insolation_variables!` was manually called by ClimaCoupler as part of the coupling loop https://github.com/CliMA/ClimaCoupler.jl/blob/a3b32d169137f7dad2edf33fd2f5e29ebd6d5356/experiments/ClimaEarth/components/atmosphere/climaatmos.jl#L394 My guess is that this is because we wanted to update it more frequently than a radiation timestep. Maybe the point was to obtain `cos_zenith_angle`? In this commit, I unconditionally update the insolation_tuple. I will also change ClimaCoupler to update it as it used to do, but I think that won't be needed after we remove `cos_zenith_angle` as an exchange field.
1 parent acb0e0d commit afe6f3e

File tree

1 file changed

+1
-4
lines changed

1 file changed

+1
-4
lines changed

src/callbacks/callbacks.jl

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -223,10 +223,7 @@ NVTX.@annotate function rrtmgp_model_callback!(integrator)
223223
end
224224
end
225225

226-
if p.atmos.insolation isa IdealizedInsolation ||
227-
!(p.atmos.surface_albedo isa CouplerAlbedo)
228-
set_insolation_variables!(Y, p, t, p.atmos.insolation)
229-
end
226+
set_insolation_variables!(Y, p, t, p.atmos.insolation)
230227

231228
if radiation_mode isa RRTMGPI.AllSkyRadiation ||
232229
radiation_mode isa RRTMGPI.AllSkyRadiationWithClearSkyDiagnostics

0 commit comments

Comments
 (0)