test overwrite

Author: szy21

.buildkite/Manifest-v1.11.toml

@@ -2540,8 +2540,8 @@ version = "1.0.2"
 
 [[deps.Thermodynamics]]
 deps = ["DocStringExtensions", "ForwardDiff", "KernelAbstractions", "Random", "RootSolvers"]
-git-tree-sha1 = "1a0e57d536d10f5bf3c7d0ab8e672321f2f89778"
-repo-rev = "zs/test_derivatives"
+git-tree-sha1 = "1c6b10882d535f28b5c79be9d8d782a12f5592f9"
+repo-rev = "zs/test_autodiff"
 repo-url = "https://github.com/CliMA/Thermodynamics.jl.git"
 uuid = "b60c26fb-14c3-4610-9d3e-2d17fe7ff00c"
 version = "0.12.15"

src/prognostic_equations/implicit/autodiff_utils.jl

@@ -143,6 +143,29 @@ end
     return ForwardDiff.dual_definition_retval(tag, val, deriv, partials)
 end
 
+# Set the derivative of max(x, y) to handle cases where x == y. When x == y,
+# the derivative is set to the derivative of x (the first argument) to ensure
+# continuity and avoid numerical issues. This is a common approach in automatic
+# differentiation for max functions.
+
+@inline function Base.max(d::ForwardDiff.Dual{Jacobian}, r::Integer)
+    tag = Val(Jacobian)
+    x = ForwardDiff.value(d)
+    partials = ForwardDiff.partials(d)
+    val = max(x, r)
+    deriv = 1
+    return ForwardDiff.dual_definition_retval(tag, val, deriv, partials)
+end
+
+# @inline function Base.clamp(d::ForwardDiff.Dual{Jacobian}, r1::FT, r2::FT) where {FT}
+#     tag = Val(Jacobian)
+#     x = ForwardDiff.value(d)
+#     partials = ForwardDiff.partials(d)
+#     val = clamp(x, r1, r2)
+#     deriv = 1
+#     return ForwardDiff.dual_definition_retval(tag, val, deriv, partials)
+# end
+
 # Ignore all derivative information when comparing Duals to other Numbers. This
 # ensures that conditional statements are always equivalent for Duals and Reals.
 for func in (:iszero,)