Try simple for-statement

Author: charleskawczynski

src/parameterized_tendencies/les_sgs_models/smagorinsky_lilly.jl

@@ -107,7 +107,7 @@ function horizontal_smagorinsky_lilly_tendency!(Yₜ, Y, p, t, ::SmagorinskyLill
     @. Yₜ.c.ρe_tot += wdivₕ(Y.c.ρ * ᶜD_smag * gradₕ(ᶜh_tot))
 
     ## Tracer diffusion and associated mass changes
-    UU.unrolled_foreach(propertynames(Yₜ.c)) do ρχ_name
+    for ρχ_name in propertynames(Yₜ.c)
         if is_tracer_var(ρχ_name) && ρχ_name != :ρe_tot
             ᶜρχ = getproperty(Y.c, ρχ_name)
             ᶜρχₜ = getproperty(Yₜ.c, ρχ_name)
@@ -160,7 +160,7 @@ function vertical_smagorinsky_lilly_tendency!(Yₜ, Y, p, t, ::SmagorinskyLilly)
     @. Yₜ.c.ρe_tot -= ᶜdivᵥ_ρe_tot(-(ᶠρ * ᶠD_smag * ᶠgradᵥ(ᶜh_tot)))
 
     ## Tracer diffusion and associated mass changes
-    UU.unrolled_foreach(propertynames(Yₜ.c)) do ρχ_name
+    for ρχ_name in propertynames(Yₜ.c)
         if is_tracer_var(ρχ_name) && ρχ_name != :ρe_tot
             ᶜρχ = getproperty(Y.c, ρχ_name)
             ᶜρχₜ = getproperty(Yₜ.c, ρχ_name)

src/prognostic_equations/advection.jl

@@ -213,7 +213,7 @@ NVTX.@annotate function explicit_vertical_advection_tendency!(Yₜ, Y, p, t)
     ᶜρ = Y.c.ρ
 
     # Full vertical advection of passive tracers (like liq, rai, etc) ...
-    UU.unrolled_foreach(propertynames(Yₜ.c)) do ρχ_name
+    for ρχ_name in propertynames(Yₜ.c)
         if is_tracer_var(ρχ_name) && !(ρχ_name in (:ρe_tot, :ρq_tot))
             ᶜρχ = getproperty(Y.c, ρχ_name)
             ᶜρχₜ = getproperty(Yₜ.c, ρχ_name)

src/prognostic_equations/remaining_tendency.jl

@@ -166,7 +166,7 @@ NVTX.@annotate function additional_tendency!(Yₜ, Y, p, t)
     @. Yₜ.c.ρe_tot += vst_ρe_tot
 
     # TODO: can we write this out explicitly?
-    UU.unrolled_foreach(propertynames(Yₜ.c)) do ρχ_name
+    for ρχ_name in propertynames(Yₜ.c)
         if is_tracer_var(ρχ_name) && ρχ_name != :ρe_tot
             ᶜρχ = getproperty(Y.c, ρχ_name)
             ᶜρχₜ = getproperty(Yₜ.c, ρχ_name)

src/prognostic_equations/surface_flux.jl

@@ -115,7 +115,7 @@ function surface_flux_tendency!(Yₜ, Y, p, t)
     btt = boundary_tendency_scalar(ᶜh_tot, sfc_conditions.ρ_flux_h_tot)
     @. Yₜ.c.ρe_tot -= btt
     ρ_flux_χ = p.scratch.sfc_temp_C3
-    UU.unrolled_foreach(propertynames(Yₜ.c)) do ρχ_name
+    for ρχ_name in propertynames(Yₜ.c)
         if is_tracer_var(ρχ_name) && ρχ_name != :ρe_tot
             ᶜρχ = getproperty(Y.c, ρχ_name)
             ᶜρχₜ = getproperty(Yₜ.c, ρχ_name)

src/prognostic_equations/vertical_diffusion_boundary_layer.jl

@@ -96,7 +96,7 @@ function vertical_diffusion_boundary_layer_tendency!(
 
     ᶜρχₜ_diffusion = p.scratch.ᶜtemp_scalar
     ᶜK_h_scaled = p.scratch.ᶜtemp_scalar_2
-    UU.unrolled_foreach(propertynames(Yₜ.c)) do ρχ_name
+    for ρχ_name in propertynames(Yₜ.c)
         if is_tracer_var(ρχ_name) && ρχ_name != :ρe_tot
             ᶜρχ = getproperty(Y.c, ρχ_name)
             ᶜρχₜ = getproperty(Yₜ.c, ρχ_name)