Fix LongLat in default coordinates for Remapper

Latitude and longitudes were flipped in the default target coordiantes
in the remapper, leading to non-sense.

Author: Sbozzolo

NEWS.md

@@ -4,6 +4,9 @@ ClimaCore.jl Release Notes
 main
 -------
 
+- Latitude and longitudes were flipped in the default target coordiantes
+in the remapper, leading to non-sense values.
+
 v0.14.33
 -------
 

src/Remapping/remapping_utils.jl

@@ -175,8 +175,8 @@ function default_target_hcoords_as_vectors(
     topology = Spaces.topology(space)
     domain = Meshes.domain(topology.mesh)
     if domain isa Domains.SphereDomain
-        return FT.(range(-180.0, 180.0, hresolution)),
-        FT.(range(-90.0, 90.0, hresolution))
+        return FT.(range(-90.0, 90.0, hresolution)),
+        FT.(range(-180.0, 180.0, hresolution))
     else
         x1min = Geometry.component(domain.interval1.coord_min, 1)
         x2min = Geometry.component(domain.interval2.coord_min, 1)

test/Remapping/distributed_remapping.jl

@@ -813,14 +813,14 @@ end
     )
 
     @test Remapping.default_target_hcoords(hv_center_space) == [
-        Geometry.LatLongPoint(x, y) for x in range(-180.0, 180.0, length = 180),
-        y in range(-90.0, 90.0, length = 180)
+        Geometry.LatLongPoint(x, y) for x in range(-90.0, 90.0, length = 180),
+        y in range(-180.0, 180.0, length = 180)
     ]
 
     # Purely horizontal 2D space sphere
     @test Remapping.default_target_hcoords(horzspace) == [
-        Geometry.LatLongPoint(x, y) for x in range(-180.0, 180.0, length = 180),
-        y in range(-90.0, 90.0, length = 180)
+        Geometry.LatLongPoint(x, y) for x in range(-90.0, 90.0, length = 180),
+        y in range(-180.0, 180.0, length = 180)
     ]
 
     # Purely vertical spaces