Merge branch 'CliMA:main' into main

Author: onzerem

.buildkite/pipeline.yml

@@ -920,12 +920,10 @@ steps:
       - label: "Unit: matrix field broadcasting (CPU)"
         key: unit_matrix_field_broadcasting_cpu_scalar_14
         command: "julia --color=yes --check-bounds=yes --project=.buildkite test/MatrixFields/matrix_fields_broadcasting/test_scalar_14.jl"
-        soft_fail: true
 
       - label: "Unit: matrix field broadcasting (CPU)"
         key: unit_matrix_field_broadcasting_cpu_scalar_15
         command: "julia --color=yes --check-bounds=yes --project=.buildkite test/MatrixFields/matrix_fields_broadcasting/test_scalar_15.jl"
-        soft_fail: true
 
       - label: "Unit: matrix field broadcasting (CPU)"
         key: unit_matrix_field_broadcasting_cpu_scalar_16
@@ -1068,7 +1066,6 @@ steps:
       - label: "Unit: matrix field broadcasting (GPU)"
         key: unit_matrix_field_broadcasting_gpu_scalar_13
         command: "julia --color=yes --check-bounds=yes --project=.buildkite test/MatrixFields/matrix_fields_broadcasting/test_scalar_13.jl"
-        soft_fail: true # due to PTX error
         env:
           CLIMACOMMS_DEVICE: "CUDA"
         agents:
@@ -1129,7 +1126,6 @@ steps:
         command: "julia --color=yes --check-bounds=yes --project=.buildkite test/MatrixFields/matrix_fields_broadcasting/test_non_scalar_3.jl"
         env:
           CLIMACOMMS_DEVICE: "CUDA"
-        soft_fail: true
         agents:
           slurm_gpus: 1
           slurm_mem: 10GB

NEWS.md

@@ -4,6 +4,21 @@ ClimaCore.jl Release Notes
 main
 -------
 
+- Latitude and longitudes were flipped in the default target coordiantes
+in the remapper, leading to non-sense values.
+
+v0.14.33
+-------
+
+- Expanded compat for Krylov to `0.10`. [2318](https://github.com/CliMA/ClimaCore.jl/pull/2318).
+
+v0.14.32
+-------
+
+- Disabled shared memory on finite difference operators. It was found that it
+  has a severe performance penalty for more complex cases.
+  [2317](https://github.com/CliMA/ClimaCore.jl/pull/2317)
+
 - Fixed missing method for `Topologies.mesh(Topology2D)`
    [2288](https://github.com/CliMA/ClimaCore.jl/pull/2288).
 

Project.toml

@@ -1,7 +1,7 @@
 name = "ClimaCore"
 uuid = "d414da3d-4745-48bb-8d80-42e94e092884"
 authors = ["CliMA Contributors <[email protected]>"]
-version = "0.14.31"
+version = "0.14.33"
 
 [deps]
 Adapt = "79e6a3ab-5dfb-504d-930d-738a2a938a0e"
@@ -59,7 +59,7 @@ HDF5 = "0.16.16, 0.17"
 InteractiveUtils = "1"
 IntervalSets = "0.5, 0.6, 0.7"
 JET = "0.9"
-Krylov = "0.9"
+Krylov = "0.9, 0.10"
 KrylovKit = "0.6, 0.7, 0.8"
 LazyBroadcast = "1"
 LinearAlgebra = "1"

src/Operators/finitedifference.jl

@@ -4177,12 +4177,15 @@ end
 """
     use_fd_shmem()
 
-Allows users to, from global scope, disable finite
+Allows users to, from global scope, enable finite
 difference shmem for operators that support it.
+TODO: ~30% slowdown was noticed with CC 0.14.31 
+in Aquaplanet benchmarks. This may need attention in 
+future releases
 
 ## Usage
 ```julia
 Operators.use_fd_shmem() = false
 ```
 """
-use_fd_shmem() = true
+use_fd_shmem() = false

src/Remapping/distributed_remapping.jl

@@ -910,7 +910,7 @@ function interpolate!(
 
         found_type = nameof(typeof(dest))
 
-        dest isa expected_array_type ||
+        parent(dest) isa expected_array_type ||
             error("dest is a $found_type, expected $expected_array_type")
     end
     index_field_begin, index_field_end =

src/Remapping/remapping_utils.jl

@@ -175,8 +175,8 @@ function default_target_hcoords_as_vectors(
     topology = Spaces.topology(space)
     domain = Meshes.domain(topology.mesh)
     if domain isa Domains.SphereDomain
-        return FT.(range(-180.0, 180.0, hresolution)),
-        FT.(range(-90.0, 90.0, hresolution))
+        return FT.(range(-90.0, 90.0, hresolution)),
+        FT.(range(-180.0, 180.0, hresolution))
     else
         x1min = Geometry.component(domain.interval1.coord_min, 1)
         x2min = Geometry.component(domain.interval2.coord_min, 1)

test/Remapping/distributed_remapping.jl

@@ -813,14 +813,14 @@ end
     )
 
     @test Remapping.default_target_hcoords(hv_center_space) == [
-        Geometry.LatLongPoint(x, y) for x in range(-180.0, 180.0, length = 180),
-        y in range(-90.0, 90.0, length = 180)
+        Geometry.LatLongPoint(x, y) for x in range(-90.0, 90.0, length = 180),
+        y in range(-180.0, 180.0, length = 180)
     ]
 
     # Purely horizontal 2D space sphere
     @test Remapping.default_target_hcoords(horzspace) == [
-        Geometry.LatLongPoint(x, y) for x in range(-180.0, 180.0, length = 180),
-        y in range(-90.0, 90.0, length = 180)
+        Geometry.LatLongPoint(x, y) for x in range(-90.0, 90.0, length = 180),
+        y in range(-180.0, 180.0, length = 180)
     ]
 
     # Purely vertical spaces