Merge pull request #2367 from CliMA/as/readme

update README: WeakValueDicts unmaintained

Author: akshaysridhar

README.md

@@ -47,7 +47,7 @@ ClimaCore.jl's high-level application programming interface (API) facilitates mo
     - Flexible memory layouts: Array-of-Structs (AoS), Struct-of-Arrays (SoA),Array-of-Struct-of-Arrays (AoSoA)
     - Useful overloads: `sum` (integral), `norm`, etc.
     - Compatible with [`DifferentialEquations.jl`](https://diffeq.sciml.ai/stable/) time steppers.
-* Composable operators via broadcasting: apply a function element-wise to an array; scalar values are broadcast over arrays 
+* Composable operators via broadcasting: apply a function element-wise to an array; scalar values are broadcast over arrays
 * Fusion of multiple operations; can be specialized for custom functions or argument types (e.g. `CuArray` compiles and applies a custom CUDA kernel).
 * Operators (`grad`, `div`, `interpolate`) are “pseudo-functions”: Act like functions when broadcasted over a `Field`; fuse operators and function calls.
 * Add element node size dimensions to type domain
@@ -56,3 +56,6 @@ ClimaCore.jl's high-level application programming interface (API) facilitates mo
 * Flexible memory layouts allow for flexible threading models (upcoming):
     - CPU thread over elements
     - GPU thread over nodes.
+
+Versions before and including ClimaCore.jl v0.11.7 relied on WeakValueDicts.jl, which is not thread-safe and no longer maintained.
+These versions are considered unsupported, and newer versions of ClimaCore.jl should be used.

test/Meshes/interval.jl

@@ -239,7 +239,11 @@ end
     )
     # test the mesh coordinates are eqv to dz_bottom
     @test Meshes.coordinates(mesh, 1, 1) == Geometry.ZPoint(0.0)
-    @test Meshes.coordinates(mesh, 1, 2) ≈ Geometry.ZPoint(0.02 / 45.0)
+    @test isapprox(
+        Meshes.coordinates(mesh, 1, 2),
+        Geometry.ZPoint(0.02 / 45.0),
+        rtol = 1e-3,
+    )
 
     # test the face element distance at the top of the domain is dz_top
     fₑ₋₁ = Geometry.component(Meshes.coordinates(mesh, 45, 1), 1)
@@ -280,8 +284,11 @@ end
     # test the mesh coordinates are eqv to dz_bottom
     @test Meshes.coordinates(mesh, 1, 1) == Geometry.ZPoint(-1.0)
     # test the face element distance at the top of the domain is dz_top
-    @test Meshes.coordinates(mesh, 1, nelems) ≈
-          Geometry.ZPoint(-Geometry.ZPoint(0.02 / 45.0).z)
+    @test isapprox(
+        Meshes.coordinates(mesh, 1, nelems),
+        Geometry.ZPoint(-Geometry.ZPoint(0.02 / 45.0).z),
+        rtol = 1e-3,
+    )
     fₑ₋₁ = Geometry.component(Meshes.coordinates(mesh, nelems, 1), 1)
     fₑ = Geometry.component(Meshes.coordinates(mesh, nelems, 2), 1)
     # a residual tol of ~1e-1 or 1e-2 is fine for typical use cases
@@ -308,7 +315,11 @@ end
     @test Meshes.coordinates(mesh, 1, 1) == Geometry.ZPoint(0.0)
     @test Meshes.coordinates(mesh, 1, nelems + 1) ≈ Geometry.ZPoint(1.0)
     # test the interval of the mesh coordinates at the surface is the same as dz_surface
-    @test Meshes.coordinates(mesh, 1, 2) ≈ Geometry.ZPoint(0.03 / 75.0)
+    @test isapprox(
+        Meshes.coordinates(mesh, 1, 2),
+        Geometry.ZPoint(0.03 / 75.0),
+        rtol = 1e-3,
+    )
 end
 
 @testset "IntervalMesh HyperbolicTangentStretching reverse" begin
@@ -334,7 +345,11 @@ end
     @test Meshes.coordinates(mesh, 1, 1) == Geometry.ZPoint(-1.0)
     @test Meshes.coordinates(mesh, 1, nelems + 1) ≈ Geometry.ZPoint(0.0)
     # test the interval of the mesh coordinates at the surface is the same as dz_surface
-    @test Meshes.coordinates(mesh, 1, nelems) ≈ Geometry.ZPoint(-0.03 / 75.0)
+    @test isapprox(
+        Meshes.coordinates(mesh, 1, nelems),
+        Geometry.ZPoint(-0.03 / 75.0),
+        rtol = 1e-3,
+    )
 end
 
 @testset "Truncated IntervalMesh" begin