correctly set land domain resolution when sharing surface space

Author: kmdeck

NEWS.md

@@ -6,12 +6,15 @@ ClimaCoupler.jl Release Notes
 
 ### ClimaCoupler features
 
+#### Correctly set land domain with `share_surface_space = true` PR[#1464](https://github.com/CliMA/ClimaCoupler.jl/pull/1464)
+Previously, we passed but did not use arguments related to the vertical resolution
+in `make_land_domain`. Now we correctly use the provided `dz_tuple` and `n_elements_vert`.
+
 #### Add option `detect_restart_files` PR[#1463](https://github.com/CliMA/ClimaCoupler.jl/pull/1463)
 Add a CLI option to signal whether restart files should be automatically used
 to restart a simulation. This is true by default, but can be set to false if a
 user wishes to run a simulation from the beginning, ignoring present restart files.
 
-
 #### Remove ED/EDMF aquaplanet longruns PR[#1461](https://github.com/CliMA/ClimaCoupler.jl/pull/1461)
 Removes the ED-only and diag. EDMF aquaplanet longruns.
 These can be run manually as needed for debugging, rather than running every week.

experiments/ClimaEarth/components/land/climaland_bucket.jl

@@ -68,7 +68,7 @@ function BucketSimulation(
     if isnothing(shared_surface_space)
         domain = make_land_domain(depth; nelements, dz_tuple)
     else
-        domain = make_land_domain(shared_surface_space, depth)
+        domain = make_land_domain(shared_surface_space, depth; nelements_vert = nelements[2], dz_tuple)
     end
     surface_space = domain.space.surface
     subsurface_space = domain.space.subsurface

experiments/ClimaEarth/components/land/climaland_helpers.jl

@@ -40,6 +40,7 @@ end
          shared_surface_space::CC.Spaces.SpectralElementSpace2D,
          depth::FT;
          nelements_vert::Int = 15,
+         dz_tuple::Tuple{FT, FT} = FT.((10.0, 0.05)),
          ) where {FT}
 
  Creates the land model domain from the input shared surface space and information
@@ -63,7 +64,12 @@ function make_land_domain(
         boundary_names = (:bottom, :top),
     )
 
-    vertmesh = CC.Meshes.IntervalMesh(vertdomain, CC.Meshes.Uniform(), nelems = nelements[2])
+    vertmesh = CC.Meshes.IntervalMesh(
+        vertdomain,
+        ClimaCore.Meshes.GeneralizedExponentialStretching{FT}(dz_tuple[1], dz_tuple[2]);
+        nelems = nelements_vert,
+        reverse_mode = true,
+    )
     verttopology = CC.Topologies.IntervalTopology(vertmesh)
     vert_center_space = CC.Spaces.CenterFiniteDifferenceSpace(verttopology)
     subsurface_space = CC.Spaces.ExtrudedFiniteDifferenceSpace(shared_surface_space, vert_center_space)

experiments/ClimaEarth/components/land/climaland_integrated.jl

@@ -80,7 +80,7 @@ function ClimaLandSimulation(
     if isnothing(shared_surface_space)
         domain = make_land_domain(depth; nelements, dz_tuple)
     else
-        domain = make_land_domain(shared_surface_space, depth)
+        domain = make_land_domain(shared_surface_space, depth; nelements_vert = nelements[2], dz_tuple)
     end
     surface_space = domain.space.surface
     subsurface_space = domain.space.subsurface