Remove radiative_energy_toa

`radiative_energy_toa` is a field fully owned by atmos. There is no
reason for ClimaCoupler to maintain a copy. Instead, we can directly
access the value from atmos if we need it (it's only needed for
conservation checks).

Author: Sbozzolo

experiments/ClimaEarth/setup_run.jl

@@ -418,7 +418,7 @@ function CoupledSimulation(config_dict::AbstractDict)
         Interfacer.add_coupler_fields!(coupler_field_names, sim)
     end
     # add coupler fields required to track conservation, if specified
-    energy_check && push!(coupler_field_names, :radiative_energy_flux_toa, :P_net)
+    energy_check && push!(coupler_field_names, :P_net)
 
     # allocate space for the coupler fields
     coupler_fields = Interfacer.init_coupler_fields(FT, coupler_field_names, boundary_space)

experiments/ClimaEarth/test/debug_plots_tests.jl

@@ -48,7 +48,6 @@ plot_field_names(sim::Interfacer.SurfaceStub) = (:stub_field,)
         :beta,
         :z0b_sfc,
         :z0m_sfc,
-        :radiative_energy_flux_toa,
     ]
     atmos_names = (:atmos_field,)
     surface_names = (:surface_field,)

src/ConservationChecker.jl

@@ -83,15 +83,28 @@ function check_conservation!(
     for sim in model_sims
         sim_name = Symbol(Interfacer.name(sim))
         if sim isa Interfacer.AtmosModelSimulation
-            radiative_energy_flux_toa = coupler_sim.fields.radiative_energy_flux_toa
-            # save radiation source
-            parent(radiative_energy_flux_toa) .= parent(Interfacer.get_field(sim, Val(:radiative_energy_flux_toa)))
+            radiative_energy_flux_toa = Interfacer.get_field(sim, Val(:radiative_energy_flux_toa))
+
+            # ClimaCore #1578, if radiative_energy_flux_toa comes from Fields.level
+            # TODO: Fix this in ClimaCore
+            rad_grid = CC.Spaces.grid(axes(radiative_energy_flux_toa))
+            if rad_grid isa CC.Grids.LevelGrid
+                if rad_grid.level isa CC.Utilities.PlusHalf
+                    # FaceSpace
+                    surface_integral =
+                        sum(radiative_energy_flux_toa ./ CC.Fields.Δz_field(radiative_energy_flux_toa) .* 2)
+                else
+                    # Center
+                    surface_integral = sum(radiative_energy_flux_toa ./ CC.Fields.Δz_field(radiative_energy_flux_toa))
+                end
+            else
+                surface_integral = sum(radiative_energy_flux_toa)
+            end
 
             if isempty(ccs.toa_net_source)
-                radiation_sources_accum = sum(radiative_energy_flux_toa .* FT(float(coupler_sim.Δt_cpl))) # ∫ J / m^2 dA
+                radiation_sources_accum = surface_integral * FT(float(coupler_sim.Δt_cpl)) # ∫ J / m^2 dA
             else
-                radiation_sources_accum =
-                    sum(radiative_energy_flux_toa .* FT(float(coupler_sim.Δt_cpl))) .+ ccs.toa_net_source[end] # ∫ J / m^2 dA
+                radiation_sources_accum = surface_integral * FT(float(coupler_sim.Δt_cpl)) + ccs.toa_net_source[end] # ∫ J / m^2 dA
             end
             push!(ccs.toa_net_source, radiation_sources_accum)
 
@@ -101,7 +114,6 @@ function check_conservation!(
 
             push!(previous, current)
             total += current + radiation_sources_accum
-
         elseif sim isa Interfacer.SurfaceModelSimulation
             # save surfaces
             area_fraction = Interfacer.get_field(sim, Val(:area_fraction))
@@ -120,7 +132,7 @@ function check_conservation!(
     push!(ccs.total, total)
 
     if runtime_check
-        @assert abs((total[end] - total[1]) / total[end]) < 1e-4
+        @assert abs((ccs.total[end] - ccs.total[1]) / ccs.total[end]) < 1e-4
     end
     return total
 
@@ -185,7 +197,7 @@ function check_conservation!(
     push!(ccs.total, total)
 
     if runtime_check
-        @assert abs((total[end] - total[1]) / total[end]) < 1e-4
+        @assert abs((ccs.total[end] - ccs.total[1]) / ccs.total[end]) < 1e-4
     end
 
     return total

src/Interfacer.jl

@@ -192,7 +192,6 @@ get_field(
         Val{:height_sfc},
         Val{:liquid_precipitation},
         Val{:radiative_energy_flux_sfc},
-        Val{:radiative_energy_flux_toa},
         Val{:snow_precipitation},
         Val{:turblent_energy_flux},
         Val{:turbulent_moisture_flux},

test/conservation_checker_tests.jl

@@ -55,13 +55,11 @@ for FT in (Float32, Float64)
 
         # coupler fields
         cf = (;
-            radiative_energy_flux_toa = CC.Fields.ones(space),
             P_net = CC.Fields.zeros(space),
             P_liq = CC.Fields.zeros(space),
             P_snow = CC.Fields.zeros(space),
             F_turb_moisture = CC.Fields.zeros(space),
         )
-        @. cf.radiative_energy_flux_toa = 200
         @. cf.P_liq = -100
 
         # init
@@ -82,7 +80,7 @@ for FT in (Float32, Float64)
         )
 
         # set non-zero radiation and precipitation
-        F_r = cf.radiative_energy_flux_toa
+        F_r = 200 .* CC.Fields.ones(space)
         P = cf.P_liq
         Δt = float(cs.Δt_cpl)
 
@@ -134,13 +132,11 @@ for FT in (Float32, Float64)
 
         # coupler fields
         cf = (;
-            radiative_energy_flux_toa = CC.Fields.ones(space),
             P_net = CC.Fields.zeros(space),
             P_liq = CC.Fields.zeros(space),
             P_snow = CC.Fields.zeros(space),
             F_turb_moisture = CC.Fields.zeros(space),
         )
-        @. cf.radiative_energy_flux_toa = 200
         @. cf.P_liq = -100
 
         # init