don't pass area fraction to clima sea ice

Author: juliasloan25

experiments/ClimaEarth/components/ocean/clima_seaice.jl

@@ -53,7 +53,7 @@ previous step is provided to the coupler to be used in computing fluxes.
 Specific details about the default model configuration
 can be found in the documentation for `ClimaOcean.ocean_simulation`.
 """
-function ClimaSeaIceSimulation(land_fraction, ocean; output_dir, start_date = nothing)
+function ClimaSeaIceSimulation(ocean; output_dir, start_date = nothing)
     # Initialize the sea ice with the same grid as the ocean
     grid = ocean.ocean.model.grid
     arch = OC.Architectures.architecture(grid)
@@ -119,10 +119,6 @@ function ClimaSeaIceSimulation(land_fraction, ocean; output_dir, start_date = no
     FT = CC.Spaces.undertype(boundary_space)
     area_fraction = Interfacer.remap(ice.model.ice_concentration, boundary_space)
 
-    # Overwrite ice fraction with the static land area fraction anywhere we have nonzero land area
-    #  max needed to avoid Float32 errors (see issue #271; Heisenbug on HPC)
-    @. area_fraction = max(min(area_fraction, FT(1) - land_fraction), FT(0))
-
     sim = ClimaSeaIceSimulation(
         ice,
         area_fraction,

experiments/ClimaEarth/setup_run.jl

@@ -369,7 +369,6 @@ function CoupledSimulation(config_dict::AbstractDict)
         ## sea ice model
         if ice_model == "clima_seaice"
             ice_sim = ClimaSeaIceSimulation(
-                ice_fraction,
                 ocean_sim;
                 output_dir = dir_paths.ice_output_dir,
                 start_date,

src/FieldExchanger.jl

@@ -71,7 +71,7 @@ function update_surface_fractions!(cs::Interfacer.CoupledSimulation)
 
         # Apply any additional constraints on the ocean and ice fractions if necessary
         if haskey(cs.model_sims, :ice_sim)
-            resolve_area_fractions!(ocean_sim, cs.model_sims.ice_sim, land_fraction)
+            FieldExchanger.resolve_area_fractions!(ocean_sim, cs.model_sims.ice_sim, land_fraction)
         end
     else
         cs.fields.scalar_temp1 .= 0