deprecating pull_MODIS.jl with artifacts in experiments/integrated/fluxnet

using ClimaArtifact's modis_lai_fluxnet_sites to deprecate and remove…

Author: ThanhNguyen428

Artifacts.toml

@@ -185,3 +185,10 @@ git-tree-sha1 = "c35ba0e899040cb8153226ab751f69100f475d39"
     [[mizoguchi_soil_freezing_data.download]]
     sha256 = "0027cc080ba45ba33dc790b176ec2854353ce7dce4eae4bef72963b0dd944e0b"
     url = "https://caltech.box.com/shared/static/tn1bnqjmegyetw5kzd2ixq5pbnb05s3u.gz"
+
+[modis_lai_fluxnet_sites]
+git-tree-sha1 = "cdcc1708832654d2209d267e01a3893c4b25c085"
+
+    [[modis_lai_fluxnet_sites.download]]
+    sha256 = "c74780775d98b56eed74222377604272658f59686d4d7881c7b815b6c230080b"
+    url = "https://caltech.box.com/shared/static/g6vubma6vcxulb9fl0pvzq6v0oto4iu3.gz"

experiments/integrated/fluxnet/met_drivers_FLUXNET.jl

@@ -12,11 +12,6 @@ import ClimaComms
 
 context = ClimaComms.context()
 
-# Methods for reading in the LAI data from MODIS data
-include(
-    joinpath(pkgdir(ClimaLand), "experiments/integrated/fluxnet/pull_MODIS.jl"),
-)
-
 data_path = ClimaLand.Artifacts.experiment_fluxnet_data_path(site_ID)
 driver_data = readdlm(data_path, ',')
 
@@ -180,24 +175,26 @@ radiation = ClimaLand.PrescribedRadiativeFluxes(
     earth_param_set = earth_param_set,
 )
 
-# Start and end dates of data in MODIS format
-modis_start_date = "A$(Dates.year(UTC_DATETIME[1]))$(lpad(Dates.dayofyear(UTC_DATETIME[1]), 3, "0"))"
-modis_end_date = "A$(Dates.year(UTC_DATETIME[end]))$(lpad(Dates.dayofyear(UTC_DATETIME[end]), 3, "0"))"
-
-MODIS_LAI = single_col_data_matrix(
-    parse_response(
-        check_response(
-            send_get_subset(
-                "MCD15A2H",
-                modis_start_date,
-                modis_end_date,
-                site_ID,
-                band = "Lai_500m",
-            ),
-        ),
-    ),
+# Desired start and end dates of data in MODIS format
+modis_start_date = DateTime(
+    "$(Dates.year(UTC_DATETIME[1]))-$(Dates.month(UTC_DATETIME[1]))-$(Dates.day(UTC_DATETIME[1]))T00:00:00.0",
+)
+modis_end_date = DateTime(
+    "$(Dates.year(UTC_DATETIME[end]))-$(Dates.month(UTC_DATETIME[end]))-$(Dates.day(UTC_DATETIME[end]))T00:00:00.0",
 )
 
+MODIS_LAI_path = ClimaLand.Artifacts.get_modis_lai_fluxnet_data(site_ID)
+MODIS_LAI_raw, header = readdlm(MODIS_LAI_path, ',', header = true)
+dates = DateTime.(MODIS_LAI_raw[:, 1])
+
+# Trim MODIS_LAI to start_date and end_date
+indices = findall(d -> modis_start_date <= d <= modis_end_date, dates)
+filtered_rows = MODIS_LAI_raw[indices, :]
+filtered_dates = dates[indices]
+
+# Create final matrix with properly formatted data for computation
+MODIS_LAI = hcat(filtered_dates, filtered_rows[:, 2])
+
 LAI_dt = Second(MODIS_LAI[2, 1] - MODIS_LAI[1, 1]).value
 LAI_seconds = FT.(0:LAI_dt:((length(MODIS_LAI[:, 1]) - 1) * LAI_dt))
 

experiments/integrated/fluxnet/pull_MODIS.jl

@@ -532,4 +532,18 @@ function era5_surface_data_1979_2024_path(; context = nothing)
     )
 end
 
+"""
+    get_modis_lai_fluxnet_data(site_ID; context = nothing)
+Returns the path to the folder that contains MODIS LAI data at:
+    US-Ha1, US-Var, US-NR1, US-Ha1
+from 2002 to 2025.
+"""
+function get_modis_lai_fluxnet_data(site_ID; context = nothing)
+    @assert site_ID ∈ ("US-MOz", "US-Var", "US-NR1", "US-Ha1")
+
+    folder_path = @clima_artifact("modis_lai_fluxnet_sites", context)
+    data_path = joinpath(folder_path, "modis_lai_$(site_ID).csv")
+    return data_path
+end
+
 end