Merge pull request #354 from CliMA/ck/zero2

charleskawczynski · web-flow · commit 5f1503b57768 · 2025-01-22T12:22:24.000-05:00
similar -&gt; zero
diff --git a/src/nl_solvers/newtons_method.jl b/src/nl_solvers/newtons_method.jl
@@ -561,7 +561,7 @@ function allocate_cache(alg::NewtonsMethod, x_prototype, j_prototype = nothing)
         krylov_method_cache = isnothing(krylov_method) ? nothing : allocate_cache(krylov_method, x_prototype),
         convergence_checker_cache = isnothing(convergence_checker) ? nothing :
                                     allocate_cache(convergence_checker, x_prototype),
-        Δx = similar(x_prototype),
+        Δx = zero(x_prototype),
         f = zero(x_prototype),
         j = isnothing(j_prototype) ? nothing : zero(j_prototype),
     )

Original file line number	Diff line number	Diff line change
`@@ -561,7 +561,7 @@ function allocate_cache(alg::NewtonsMethod, x_prototype, j_prototype = nothing)`
`561`	`561`	`krylov_method_cache = isnothing(krylov_method) ? nothing : allocate_cache(krylov_method, x_prototype),`
`562`	`562`	`convergence_checker_cache = isnothing(convergence_checker) ? nothing :`
`563`	`563`	`allocate_cache(convergence_checker, x_prototype),`
`564`		`- Δx = similar(x_prototype),`
	`564`	`+ Δx = zero(x_prototype),`
`565`	`565`	`f = zero(x_prototype),`
`566`	`566`	`j = isnothing(j_prototype) ? nothing : zero(j_prototype),`
`567`	`567`	`)`