Merge #102

102: Add QA tests on built integrators r=charleskawczynski a=charleskawczynski

This PR adds some QA tests for the integrators that we build.

Co-authored-by: Charles Kawczynski <[email protected]>

Author: bors[bot]

test/integrator.jl

@@ -1,6 +1,7 @@
 using ClimaTimeSteppers, Test
 import OrdinaryDiffEq
 
+include("integrator_utils.jl")
 include("problems.jl")
 
 @testset "integrator save times" begin
@@ -150,6 +151,7 @@ end
             ((; saveat = save_dt, tstops = all_times), (; erase_sol = false), all_times),
         )
             integrator = init(deepcopy(prob), alg; dt, init_kwargs...)
+            @test !@has_DataType_or_UnionAll(integrator)
             solve!(integrator)
             reinit!(integrator, u0′; t0 = t0′, tf = tf′, reinit_kwargs...)
             sol = solve!(integrator)

test/integrator_utils.jl

@@ -0,0 +1,20 @@
+function has_DataType_or_UnionAll(obj, name, pc = ())
+    for pn in propertynames(obj)
+        prop = getproperty(obj, pn)
+        pc_full = (pc..., ".", pn)
+        pc_string = name*string(join(pc_full))
+        if prop isa DataType
+            @warn "$pc_string::$(typeof(prop)) is a DataType"
+            return true
+        elseif prop isa UnionAll
+            @warn "$pc_string::$(typeof(prop)) is a UnionAll"
+            return true
+        else
+            has_DataType_or_UnionAll(prop, name, pc_full)
+        end
+    end
+    return false
+end
+macro has_DataType_or_UnionAll(obj)
+    return :(has_DataType_or_UnionAll($(esc(obj)), $(string(obj))))
+end