Skip to content

Commit 97be0c5

Browse files
committed
rename TimeManager to CallbackManager
1 parent c9b7c0c commit 97be0c5

File tree

8 files changed

+39
-40
lines changed

8 files changed

+39
-40
lines changed

README.md

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ ClimaUtilities.jl
2626
to process input data and remap it onto the simulation grid.
2727
- [`OutputPathGenerator`](https://clima.github.io/ClimaUtilities.jl/dev/outputpathgenerator/)
2828
to prepare the output directory structure of a simulation.
29-
- [`TimeManager`](https://clima.github.io/ClimaUtilities.jl/dev/timemanager/) to
29+
- [`CallbackManager`](https://clima.github.io/ClimaUtilities.jl/dev/callbackmanager/) to
3030
handle dates.
3131

3232
## ClimaUtilities.jl Developer Guidelines
@@ -178,6 +178,5 @@ two commits when the second just fixes the first).
178178

179179
The `Space` and `TimeVaryingInputs` modules were initially developed in the
180180
context of [`ClimaLand`](https://github.com/CliMA/ClimaLand.jl), the
181-
`TempestRegridder` and `TimeManager` ones were initially developed in
181+
`TempestRegridder` and `CallbackManager` ones were initially developed in
182182
[`ClimaCoupler`](https://github.com/CliMA/ClimaCoupler.jl).
183-

docs/make.jl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ pages = [
2323
"DataHandling" => "datahandling.md",
2424
"Regridders" => "regridders.md",
2525
"OutputPathGenerator" => "outputpathgenerator.md",
26-
"TimeManager" => "timemanager.md",
26+
"CallbackManager" => "callbackmanager.md",
2727
"Frequently Asked Questions" => "faqs.md",
2828
]
2929

docs/src/callbackmanager.md

Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,16 @@
1+
# CallbackManager
2+
3+
This module contains functions that handle dates and times
4+
in simulations. The functions in this module often call
5+
functions from Julia's [Dates](https://docs.julialang.org/en/v1/stdlib/Dates/) module.
6+
7+
## CallbackManager API
8+
9+
```@docs
10+
ClimaUtilities.CallbackManager.to_datetime
11+
ClimaUtilities.CallbackManager.strdate_to_datetime
12+
ClimaUtilities.CallbackManager.datetime_to_strdate
13+
ClimaUtilities.CallbackManager.trigger_callback
14+
ClimaUtilities.CallbackManager.Monthly
15+
ClimaUtilities.CallbackManager.EveryTimestep
16+
```

docs/src/timemanager.md

Lines changed: 0 additions & 16 deletions
This file was deleted.

src/TimeManager.jl renamed to src/CallbackManager.jl

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,10 @@
11
"""
2-
TimeManager
2+
CallbackManager
33
44
This module facilitates calendar functions and temporal interpolations
55
of data.
66
"""
7-
module TimeManager
7+
module CallbackManager
88

99
import Dates
1010

@@ -105,4 +105,4 @@ function trigger_callback(
105105
end
106106
end
107107

108-
end # module TimeManager
108+
end # module CallbackManager

src/ClimaUtilities.jl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ module ClimaUtilities
22

33
include("Utils.jl")
44
include("MPIUtils.jl")
5-
include("TimeManager.jl")
5+
include("CallbackManager.jl")
66
include("DataStructures.jl")
77
include("FileReaders.jl")
88
include("Regridders.jl")

test/timemanager.jl renamed to test/callbackmanager.jl

Lines changed: 14 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import ClimaUtilities: TimeManager
1+
import ClimaUtilities: CallbackManager
22
import Dates
33
import CFTime
44
using Test
@@ -9,32 +9,32 @@ for FT in (Float32, Float64)
99
year = 2001
1010
dt_noleap = CFTime.DateTimeNoLeap(year)
1111
dt = Dates.DateTime(year)
12-
@test TimeManager.to_datetime(dt_noleap) == dt
12+
@test CallbackManager.to_datetime(dt_noleap) == dt
1313
# In non-leap year, DateTime and DateTimeNoLeap are the same
14-
@test TimeManager.to_datetime(dt_noleap + Dates.Day(365)) ==
14+
@test CallbackManager.to_datetime(dt_noleap + Dates.Day(365)) ==
1515
dt + Dates.Day(365)
1616

1717
# Test leap year behavior
1818
leap_year = 2000
1919
dt_noleap_ly = CFTime.DateTimeNoLeap(leap_year)
2020
dt_ly = Dates.DateTime(leap_year)
2121
# DateTime includes leap days, DateTimeNoLeap does not, so DateTime has one extra day in leap year
22-
@test TimeManager.to_datetime(dt_noleap_ly + Dates.Day(365)) ==
22+
@test CallbackManager.to_datetime(dt_noleap_ly + Dates.Day(365)) ==
2323
dt_ly + Dates.Day(366)
2424

2525
end
2626

2727
@testset "test strdate_to_datetime for FT=$FT" begin
28-
@test TimeManager.strdate_to_datetime("19000101") ==
28+
@test CallbackManager.strdate_to_datetime("19000101") ==
2929
Dates.DateTime(1900, 1, 1)
30-
@test TimeManager.strdate_to_datetime("00000101") ==
30+
@test CallbackManager.strdate_to_datetime("00000101") ==
3131
Dates.DateTime(0, 1, 1)
3232
end
3333

3434
@testset "test datetime_to_strdate for FT=$FT" begin
35-
@test TimeManager.datetime_to_strdate(Dates.DateTime(1900, 1, 1)) ==
35+
@test CallbackManager.datetime_to_strdate(Dates.DateTime(1900, 1, 1)) ==
3636
"19000101"
37-
@test TimeManager.datetime_to_strdate(Dates.DateTime(0, 1, 1)) ==
37+
@test CallbackManager.datetime_to_strdate(Dates.DateTime(0, 1, 1)) ==
3838
"00000101"
3939
end
4040

@@ -47,10 +47,10 @@ for FT in (Float32, Float64)
4747
arg_copy = copy(arg)
4848
date_current =
4949
date_nextcall = date_nextcall_copy = Dates.DateTime(1979, 3, 21)
50-
date_nextcall = TimeManager.trigger_callback(
50+
date_nextcall = CallbackManager.trigger_callback(
5151
date_nextcall,
5252
date_current,
53-
TimeManager.Monthly(),
53+
CallbackManager.Monthly(),
5454
func!,
5555
(arg,),
5656
)
@@ -61,10 +61,10 @@ for FT in (Float32, Float64)
6161
# Case 2: date_current > date_nextcall
6262
date_nextcall = date_nextcall_copy = Dates.DateTime(1979, 3, 21)
6363
date_current = date_nextcall + Dates.Day(1)
64-
date_nextcall = TimeManager.trigger_callback(
64+
date_nextcall = CallbackManager.trigger_callback(
6565
date_nextcall,
6666
date_current,
67-
TimeManager.Monthly(),
67+
CallbackManager.Monthly(),
6868
func!,
6969
(arg,),
7070
)
@@ -75,10 +75,10 @@ for FT in (Float32, Float64)
7575
# Case 3: date_current < date_nextcall
7676
date_nextcall = date_nextcall_copy = Dates.DateTime(1979, 3, 21)
7777
date_current = date_nextcall - Dates.Day(1)
78-
date_nextcall = TimeManager.trigger_callback(
78+
date_nextcall = CallbackManager.trigger_callback(
7979
date_nextcall,
8080
date_current,
81-
TimeManager.Monthly(),
81+
CallbackManager.Monthly(),
8282
func!,
8383
(arg,),
8484
)

test/runtests.jl

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -28,8 +28,8 @@ end
2828
include("output_path_generator.jl")
2929
end
3030

31-
@safetestset "TimeManager tests" begin
32-
include("timemanager.jl")
31+
@safetestset "CallbackManager tests" begin
32+
include("callbackmanager.jl")
3333
end
3434

3535
@safetestset "DataStructures tests" begin

0 commit comments

Comments
 (0)