Use the correct velocities in VarianceDissipationComputations#5298
Merged
simone-silvestri merged 1 commit intomainfrom Feb 14, 2026
Merged
Use the correct velocities in VarianceDissipationComputations#5298simone-silvestri merged 1 commit intomainfrom
VarianceDissipationComputations#5298simone-silvestri merged 1 commit intomainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5298 +/- ##
==========================================
+ Coverage 68.79% 73.06% +4.26%
==========================================
Files 395 395
Lines 21465 22361 +896
==========================================
+ Hits 14767 16337 +1570
+ Misses 6698 6024 -674
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
glwagner
approved these changes
Feb 13, 2026
Member
|
Is this also a concern for other diagnostics? |
Member
|
For example, work to close budgets (very popular) needs to know about this. |
Collaborator
Author
|
yeah, I have in the plans to enhance the docs with some timestepping information. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
HydrostaticFreeSurfaceModelhas switched to using model.transport_velocities to advect the tracers.This needs to be reflected also in the
VarianceDissipationComputation