Remove deprecated code; add some tests

Author: tapios

.buildkite/pipeline.yml

@@ -31,7 +31,7 @@ steps:
 
   - label: "CPU tests"
     command:
-      - "THERMODYNAMICS_INCLUDE_DEPRECATED=false julia --project=test/ --color=yes test/runtests.jl"
+      - "julia --project=test/ --color=yes test/runtests.jl"
     agents:
       slurm_ntasks: 1
     timeout_in_minutes: 60

docs/src/API.md

@@ -156,76 +156,3 @@ TemperatureProfiles.DryAdiabaticProfile
 Thermodynamics.DataCollection
 ```
 
-## Deprecated Functions
-
-These functions are deprecated and will be removed in a future release.
-
-### Backward Compatibility Wrappers
-
-These wrappers exist for backward compatibility with older versions of the package.
-
-```@docs
-specific_enthalpy
-specific_enthalpy_dry
-specific_enthalpy_vapor
-specific_enthalpy_liquid
-specific_enthalpy_ice
-dry_pottemp
-total_specific_enthalpy
-q_vap_saturation_generic
-latent_heat_liq_ice
-```
-
-### Other Deprecated Functions
-
-```@docs
-air_temperature_given_hq
-air_temperature_given_pρq
-air_temperature_given_pθq
-air_temperature_given_ρθq
-air_temperature_given_ρθq_nonlinear
-saturated
-total_specific_humidity
-liquid_specific_humidity
-ice_specific_humidity
-mixing_ratios
-specific_volume
-q_vap_from_RH_liquid
-temperature_and_humidity_given_TᵥρRH
-liquid_ice_pottemp_sat
-PhasePartition_equil
-PhasePartition_equil_given_p
-```
-
-## Thermodynamic State Constructors (Deprecated)
-
-```@docs
-ThermodynamicState
-PhasePartition
-PhaseDry
-PhaseDry_ρe
-PhaseDry_pT
-PhaseDry_pθ
-PhaseDry_pe
-PhaseDry_ph
-PhaseDry_ρθ
-PhaseDry_ρT
-PhaseDry_ρp
-PhaseEquil
-PhaseEquil_ρeq
-PhaseEquil_ρTq
-PhaseEquil_pTq
-PhaseEquil_pθq
-PhaseEquil_peq
-PhaseEquil_phq
-PhaseEquil_ρθq
-PhaseEquil_ρpq
-PhaseNonEquil
-PhaseNonEquil_ρTq
-PhaseNonEquil_pTq
-PhaseNonEquil_ρθq
-PhaseNonEquil_pθq
-PhaseNonEquil_peq
-PhaseNonEquil_phq
-PhaseNonEquil_ρpq
-```

perf/common.jl

@@ -17,7 +17,7 @@ using .TestedProfiles
     functional_inputs(param_set, ::Type{FT}; n=256)
 
 Construct equilibrium-consistent scalar inputs for functional benchmarks, derived from
-`test/TestedProfiles.jl` (no deprecated PhasePartition/state types).
+`test/TestedProfiles.jl`.
 """
 function functional_inputs(param_set, ::Type{FT}; n = 256) where {FT}
     ps = TestedProfiles.PhaseEquilProfiles(param_set, Array{FT})

perf/microbenchmarks.jl

@@ -1,6 +1,6 @@
 include("common_micro_bm.jl")
 
-function benchmark_thermo_states(::Type{FT}) where {FT}
+function benchmark_functional_api(::Type{FT}) where {FT}
     summary = OrderedCollections.OrderedDict()
     ArrayType = Array{FT}
     param_set = TP.ThermodynamicsParameters(FT)
@@ -25,5 +25,5 @@ function benchmark_thermo_states(::Type{FT}) where {FT}
     tabulate_summary(summary)
 end
 
-benchmark_thermo_states(Float64)
-benchmark_thermo_states(Float32)
+benchmark_functional_api(Float64)
+benchmark_functional_api(Float32)

src/Thermodynamics.jl

@@ -60,8 +60,6 @@ const APS = TP.AbstractThermodynamicsParameters
 
 include("ThermoTypes.jl")
 
-include("depr_PhasePartitionTypes.jl")
-
 @inline solution_type() = RS.CompactSolution()
 include("DataCollection.jl")
 import .DataCollection
@@ -80,13 +78,6 @@ include("air_entropies.jl")
 include("air_dry_adiabatic.jl")
 include("TemperatureProfiles.jl")
 
-# Soon to be removed
-include("depr_air_temperatures.jl")
-include("depr_saturation_adjustment.jl")
-include("depr_air_states.jl")
-include("depr_state_methods.jl")
-include("depr_phase_partition_methods.jl")
-
 Base.broadcastable(dap::DryAdiabaticProcess) = tuple(dap)
 Base.broadcastable(phase::Phase) = tuple(phase)
 

src/air_humidities.jl

@@ -6,7 +6,6 @@ export partial_pressure_vapor
 export specific_humidity_to_mixing_ratio
 export q_vap_from_p_vap
 export q_vap_from_RH
-export q_vap_from_RH_liquid
 export relative_humidity
 
 """
@@ -193,26 +192,6 @@ Compute the vapor specific humidity from the relative humidity.
     return p_vap / Rv_over_Rd / (p - (1 - 1 / Rv_over_Rd) * p_vap)
 end
 
-"""
-    q_vap_from_RH_liquid(param_set, p, T, RH)
-
-Compute the vapor specific humidity from the relative humidity over liquid.
-
-# Arguments
- - `param_set`: thermodynamics parameter set, see [`Thermodynamics`](@ref)
- - `p`: pressure [Pa]
- - `T`: temperature [K]
- - `RH`: relative humidity [dimensionless], 0 ≤ RH ≤ 1
-
-# Returns
- - `q_vap`: vapor specific humidity [kg/kg]
-
-This function is deprecated. Use `q_vap_from_RH` with `Liquid()` instead.
-"""
-@inline function q_vap_from_RH_liquid(param_set::APS, p, T, RH)
-    return q_vap_from_RH(param_set, p, T, RH, Liquid())
-end
-
 """
     relative_humidity(param_set, T, p, q_tot=0, q_liq=0, q_ice=0)
 

src/air_temperatures.jl

@@ -26,10 +26,10 @@ This method inverts [`internal_energy`](@ref) by solving for `T` given `e_int`.
 """
 @inline function air_temperature(
     param_set::APS,
-    e_int::Real,     # Number type needed to disambiguate from deprecated methods that are still there
-    q_tot::Real = 0,
-    q_liq::Real = 0,
-    q_ice::Real = 0,
+    e_int,     
+    q_tot = 0,
+    q_liq = 0,
+    q_ice = 0,
 )
     return air_temperature(param_set, ρe(), e_int, q_tot, q_liq, q_ice)
 end