fix storage class issue preventing upgrades + add tests

Author: teeohhem

charts/hdx-oss-v2/templates/claims/persistent-volume-claims.yaml

@@ -8,7 +8,9 @@ metadata:
 spec:
   accessModes:
     - ReadWriteOnce
+  {{- if .Values.global.storageClass }}
   storageClassName: {{ .Values.global.storageClass }}
+  {{- end }}
   resources:
     requests:
       storage: {{ .Values.persistence.mongodb.size }}

charts/hdx-oss-v2/templates/clickhouse-deployment.yaml

@@ -105,7 +105,9 @@ metadata:
 spec:
   accessModes:
     - ReadWriteOnce
+  {{- if .Values.global.storageClass }}
   storageClassName: {{ .Values.global.storageClass }}
+  {{- end }}
   resources:
     requests:
       storage: {{ .Values.clickhouse.persistence.dataSize }}
@@ -119,7 +121,9 @@ metadata:
 spec:
   accessModes:
     - ReadWriteOnce
+  {{- if .Values.global.storageClass }}
   storageClassName: {{ .Values.global.storageClass }}
+  {{- end }}
   resources:
     requests:
       storage: {{ .Values.clickhouse.persistence.logSize }}

charts/hdx-oss-v2/tests/clickhouse-deployment_test.yaml

@@ -33,4 +33,42 @@ tests:
           of: PersistentVolumeClaim
       - documentIndex: 5
         isKind:
-          of: PersistentVolumeClaim 
+          of: PersistentVolumeClaim
+
+  - it: should include storageClassName when global.storageClass is set
+    set:
+      global:
+        storageClass: "fast-ssd"
+      clickhouse:
+        enabled: true
+        persistence:
+          enabled: true
+          dataSize: 10Gi
+          logSize: 5Gi
+    asserts:
+      - documentIndex: 4
+        equal:
+          path: spec.storageClassName
+          value: "fast-ssd"
+      - documentIndex: 5
+        equal:
+          path: spec.storageClassName
+          value: "fast-ssd"
+
+  - it: should omit storageClassName when global.storageClass is empty
+    set:
+      global:
+        storageClass: ""
+      clickhouse:
+        enabled: true
+        persistence:
+          enabled: true
+          dataSize: 10Gi
+          logSize: 5Gi
+    asserts:
+      - documentIndex: 4
+        isNull:
+          path: spec.storageClassName
+      - documentIndex: 5
+        isNull:
+          path: spec.storageClassName 

charts/hdx-oss-v2/tests/persistence_test.yaml

@@ -30,4 +30,18 @@ tests:
           enabled: false
     asserts:
       - hasDocuments:
-          count: 0
+          count: 0
+
+  - it: should omit storageClassName when global.storageClass is empty string
+    set:
+      global:
+        storageClass: ""
+      persistence:
+        mongodb:
+          enabled: true
+          size: 10Gi
+    asserts:
+      - isKind:
+          of: PersistentVolumeClaim
+      - isNull:
+          path: spec.storageClassName

charts/hdx-oss-v2/tests/pvc_test.yaml

@@ -33,4 +33,30 @@ tests:
           enabled: false
     asserts:
       - hasDocuments:
-          count: 0 
+          count: 0
+
+  - it: should not include storageClassName when global.storageClass is empty
+    set:
+      persistence:
+        mongodb:
+          enabled: true
+          size: 10Gi
+      global:
+        storageClass: ""
+    asserts:
+      - isKind:
+          of: PersistentVolumeClaim
+      - isNull:
+          path: spec.storageClassName
+
+  - it: should not include storageClassName when global.storageClass is not set
+    set:
+      persistence:
+        mongodb:
+          enabled: true
+          size: 10Gi
+    asserts:
+      - isKind:
+          of: PersistentVolumeClaim
+      - isNull:
+          path: spec.storageClassName 

charts/hdx-oss-v2/values.yaml

@@ -1,7 +1,7 @@
 global:
   imageRegistry: ""
   imagePullSecrets: []
-  storageClassName: []
+  storageClassName: "local-path"
 
 hyperdx:
   image: "hyperdx/hyperdx:2-beta"