fix: don't hardcode NEXT_PUBLIC_URL with localhost in app configmap

Author: teeohhem

charts/hdx-oss-v2/templates/configmaps/app-configmap.yaml

@@ -14,7 +14,7 @@ data:
   HYPERDX_LOG_LEVEL: "{{ .Values.hyperdx.logLevel }}"
   MINER_API_URL: "http://{{ include "hdx-oss.fullname" . }}-miner:5123"
   MONGO_URI: "{{ tpl .Values.hyperdx.mongoUri . }}"
-  NEXT_PUBLIC_SERVER_URL: "http://localhost:{{ .Values.hyperdx.apiPort }}"
+  NEXT_PUBLIC_SERVER_URL: "{{ .Values.hyperdx.appUrl }}:{{ .Values.hyperdx.apiPort }}"
   OTEL_SERVICE_NAME: "hdx-oss-api"
   USAGE_STATS_ENABLED: "{{ .Values.hyperdx.usageStatsEnabled | default true }}"
   CRON_IN_APP_DISABLED: "{{ .Values.tasks.enabled | default false }}"

charts/hdx-oss-v2/tests/configmap_test.yaml

@@ -38,6 +38,56 @@ tests:
       - equal:
           path: data.CRON_IN_APP_DISABLED
           value: "false"
+      - equal:
+          path: data.NEXT_PUBLIC_SERVER_URL
+          value: "http://localhost:8000"
       - matchRegex:
           path: data.MONGO_URI
-          pattern: mongodb://.*-mongodb:27017/hyperdx 
+          pattern: mongodb://.*-mongodb:27017/hyperdx
+
+  - it: should render NEXT_PUBLIC_SERVER_URL with custom appUrl and apiPort
+    set:
+      hyperdx:
+        apiPort: 9000
+        appPort: 4000
+        appUrl: https://my-hyperdx.example.com
+        logLevel: debug
+        usageStatsEnabled: false
+      mongodb:
+        port: 27017
+      tasks:
+        enabled: true
+    asserts:
+      - isKind:
+          of: ConfigMap
+      - equal:
+          path: data.NEXT_PUBLIC_SERVER_URL
+          value: "https://my-hyperdx.example.com:9000"
+      - equal:
+          path: data.FRONTEND_URL
+          value: "https://my-hyperdx.example.com:4000"
+      - equal:
+          path: data.HYPERDX_APP_URL
+          value: "https://my-hyperdx.example.com"
+
+  - it: should render NEXT_PUBLIC_SERVER_URL with HTTP URL
+    set:
+      hyperdx:
+        apiPort: 8080
+        appPort: 3000
+        appUrl: http://192.168.1.100
+    asserts:
+      - equal:
+          path: data.NEXT_PUBLIC_SERVER_URL
+          value: "http://192.168.1.100:8080"
+
+  - it: should render NEXT_PUBLIC_SERVER_URL with HTTPS URL
+    set:
+      hyperdx:
+        apiPort: 443
+        appPort: 80
+        appUrl: https://secure.hyperdx.io
+    asserts:
+      - equal:
+          path: data.NEXT_PUBLIC_SERVER_URL
+          value: "https://secure.hyperdx.io:443"