fix: add protocol to default opamp url

Author: teeohhem

charts/hdx-oss-v2/templates/otel-collector-deployment.yaml

@@ -37,7 +37,7 @@ spec:
               value: "{{ .Values.otel.clickhousePrometheusEndpoint | default (printf "%s-clickhouse:%v" (include "hdx-oss.fullname" .) .Values.clickhouse.prometheus.port ) }}"
             {{- end }}
             - name: OPAMP_SERVER_URL
-              value: {{ .Values.otel.opampServerUrl | default (printf "%s-app:%v" (include "hdx-oss.fullname" .) .Values.hyperdx.opampPort ) }}
+              value: {{ .Values.otel.opampServerUrl | default (printf "http://%s-app:%v" (include "hdx-oss.fullname" .) .Values.hyperdx.opampPort ) }}
             - name: HYPERDX_LOG_LEVEL
               value: {{ .Values.hyperdx.logLevel }}
             - name: HYPERDX_API_KEY

charts/hdx-oss-v2/tests/otel-collector_test.yaml

@@ -88,6 +88,12 @@ tests:
           content:
             name: CLICKHOUSE_PASSWORD
             value: test-password
+      - documentIndex: 0
+        contains:
+          path: spec.template.spec.containers[0].env
+          content:
+            name: OPAMP_SERVER_URL
+            value: http://test-release-hdx-oss-v2-app:4320
 
   - it: should render environment variables correctly with custom clickhouse endpoint
     set:
@@ -276,4 +282,29 @@ tests:
         notContains:
           path: spec.template.spec.containers[0].env
           content:
-            name: CLICKHOUSE_PROMETHEUS_METRICS_ENDPOINT
+            name: CLICKHOUSE_PROMETHEUS_METRICS_ENDPOINT
+
+  - it: should render OPAMP_SERVER_URL with custom value when specified
+    set:
+      otel:
+        enabled: true
+        image: hyperdx/hyperdx-otel-collector:2-beta
+        opampServerUrl: "https://custom-opamp-server:8080"
+      hyperdx:
+        logLevel: info
+      clickhouse:
+        config:
+          users:
+            otelUserPassword: test-password
+    release:
+      name: test-release
+    asserts:
+      - documentIndex: 0
+        isKind:
+          of: Deployment
+      - documentIndex: 0
+        contains:
+          path: spec.template.spec.containers[0].env
+          content:
+            name: OPAMP_SERVER_URL
+            value: "https://custom-opamp-server:8080"