fix(alert): corrected code path and version check

Author: dhable

.changeset/smart-mammals-invent.md

@@ -0,0 +1,5 @@
+---
+"helm-charts": patch
+---
+
+Further fixes to the cronjob to use the correct path and version.

charts/hdx-oss-v2/templates/cronjobs/task-checkAlerts.yaml

@@ -27,10 +27,10 @@ spec:
               image: "{{ .Values.hyperdx.image.repository }}:{{ .Values.hyperdx.image.tag | default .Chart.AppVersion }}"
               imagePullPolicy: {{ .Values.hyperdx.image.pullPolicy }}
               {{- $tag := .Values.hyperdx.image.tag | default .Chart.AppVersion -}}
-              {{- if and (regexMatch "^[0-9]+\\.[0-9]+\\.[0-9]+" $tag) (semverCompare "< 2.7.1" $tag) }} # before esbuild revert
+              {{- if and (regexMatch "^[0-9]+\\.[0-9]+\\.[0-9]+" $tag) (semverCompare "< 2.7.0" $tag) }} # before esbuild revert
               command: ["node", "/app/packages/api/tasks/index", "check-alerts"]
               {{- else }}
-              command: ["node", "/app/api/build/tasks/index.js", "check-alerts"] # after esbuild revert
+              command: ["node", "/app/packages/api/build/tasks/index.js", "check-alerts"] # after esbuild revert
               {{- end }}
               envFrom:
                 - configMapRef:

charts/hdx-oss-v2/tests/task-checkAlerts_test.yaml

@@ -38,7 +38,7 @@ tests:
           value: hyperdx/hyperdx:2-beta
       - equal:
           path: spec.jobTemplate.spec.template.spec.containers[0].command
-          value: ["node", "/app/api/build/tasks/index.js", "check-alerts"]
+          value: ["node", "/app/packages/api/build/tasks/index.js", "check-alerts"]
       - isSubset:
           path: spec.jobTemplate.spec.template.spec.containers[0].resources
           content:
@@ -95,31 +95,31 @@ tests:
           path: spec.jobTemplate.spec.template.spec.imagePullSecrets[0].name
           value: regcred
 
-  - it: should use esbuild command path for versions before 2.7.1
+  - it: should use esbuild command path for version 2.6.0
     set:
       tasks:
         enabled: true
       hyperdx:
         image:
-          tag: "2.7.0"
+          tag: "2.6.0"
     asserts:
       - equal:
           path: spec.jobTemplate.spec.template.spec.containers[0].command
           value: ["node", "/app/packages/api/tasks/index", "check-alerts"]
 
-  - it: should use esbuild command path for version 2.6.0
+  - it: should use post-esbuild command path for version 2.7.0
     set:
       tasks:
         enabled: true
       hyperdx:
         image:
-          tag: "2.6.0"
+          tag: "2.7.0"
     asserts:
       - equal:
           path: spec.jobTemplate.spec.template.spec.containers[0].command
-          value: ["node", "/app/packages/api/tasks/index", "check-alerts"]
+          value: ["node", "/app/packages/api/build/tasks/index.js", "check-alerts"]
 
-  - it: should use post-esbuild command path for version 2.7.1
+  - it: should use post-esbuild command path for versions after 2.7.0 (patch)
     set:
       tasks:
         enabled: true
@@ -129,9 +129,9 @@ tests:
     asserts:
       - equal:
           path: spec.jobTemplate.spec.template.spec.containers[0].command
-          value: ["node", "/app/api/build/tasks/index.js", "check-alerts"]
+          value: ["node", "/app/packages/api/build/tasks/index.js", "check-alerts"]
 
-  - it: should use post-esbuild command path for versions after 2.7.1
+  - it: should use post-esbuild command path for versions after 2.7.0 (minor)
     set:
       tasks:
         enabled: true
@@ -141,9 +141,9 @@ tests:
     asserts:
       - equal:
           path: spec.jobTemplate.spec.template.spec.containers[0].command
-          value: ["node", "/app/api/build/tasks/index.js", "check-alerts"]
+          value: ["node", "/app/packages/api/build/tasks/index.js", "check-alerts"]
 
-  - it: should use post-esbuild command path for version 3.0.0
+  - it: should use post-esbuild command path for version 3.0.0 (major)
     set:
       tasks:
         enabled: true
@@ -153,4 +153,4 @@ tests:
     asserts:
       - equal:
           path: spec.jobTemplate.spec.template.spec.containers[0].command
-          value: ["node", "/app/api/build/tasks/index.js", "check-alerts"]
+          value: ["node", "/app/packages/api/build/tasks/index.js", "check-alerts"]