chore: Remove snapshot tests and replace with assertions (#34)

Co-authored-by: Warren <[email protected]>

Author: teeohhem

.changeset/thin-steaks-hammer.md

@@ -0,0 +1,5 @@
+---
+"helm-charts": patch
+---
+
+chore: Remove snapshot tests and replace with assertions

.github/workflows/release.yml

@@ -29,6 +29,10 @@ jobs:
         run: yarn
       - name: Create Release Pull Request
         uses: changesets/action@v1
+        with:
+          commit: 'chore(release): bump version'
+          title: 'Release HyperDX Helm Charts'
+          version: yarn run version
         env:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
       - name: Run chart-releaser job

charts/hdx-oss-v2/tests/__snapshot__/ingress_test.yaml.snap

@@ -29,8 +29,29 @@ tests:
       - equal:
           path: spec.rules[0].host
           value: hyperdx.example.com
-      - matchSnapshot:
-          path: metadata.annotations
+      # Validate ingress annotations
+      - equal:
+          path: metadata.annotations["nginx.ingress.kubernetes.io/proxy-body-size"]
+          value: "100m"
+      - equal:
+          path: metadata.annotations["nginx.ingress.kubernetes.io/proxy-connect-timeout"]
+          value: "60"
+      - equal:
+          path: metadata.annotations["nginx.ingress.kubernetes.io/proxy-read-timeout"]
+          value: "60"
+      - equal:
+          path: metadata.annotations["nginx.ingress.kubernetes.io/proxy-send-timeout"]
+          value: "60"
+      - equal:
+          path: metadata.annotations["nginx.ingress.kubernetes.io/rewrite-target"]
+          value: "/$1"
+      - equal:
+          path: metadata.annotations["nginx.ingress.kubernetes.io/use-regex"]
+          value: "true"
+      # Validate chart version format without exact match
+      - matchRegex:
+          path: metadata.labels["helm.sh/chart"]
+          pattern: ^hdx-oss-v2-\d+\.\d+\.\d+$
 
   - it: should render ingress with TLS when enabled
     set:

charts/hdx-oss-v2/tests/__snapshot__/otel-collector-disabled_test.yaml.snap

@@ -31,7 +31,67 @@ tests:
     asserts:
       - hasDocuments:
           count: 2
-      - matchSnapshot: {}
+      # App secrets validation
+      - isKind:
+          of: Secret
+        documentIndex: 0
+      - equal:
+          path: metadata.name
+          value: RELEASE-NAME-hdx-oss-v2-app-secrets
+        documentIndex: 0
+      - equal:
+          path: type
+          value: Opaque
+        documentIndex: 0
+      - isNotEmpty:
+          path: data.api-key
+        documentIndex: 0
+      # ClickHouse secrets validation  
+      - isKind:
+          of: Secret
+        documentIndex: 1
+      - equal:
+          path: metadata.name
+          value: RELEASE-NAME-hdx-oss-v2-clickhouse-secrets
+        documentIndex: 1
+      - equal:
+          path: type
+          value: Opaque
+        documentIndex: 1
+      - equal:
+          path: data.appUserPassword
+          value: dGVzdC1wYXNzd29yZA==
+        documentIndex: 1
+      - equal:
+          path: data.otelUserPassword
+          value: dGVzdC1vdGVsLXBhc3N3b3Jk
+        documentIndex: 1
+      # Validate standard labels exist (without checking helm.sh/chart)
+      - isSubset:
+          path: metadata.labels
+          content:
+            app.kubernetes.io/instance: RELEASE-NAME
+            app.kubernetes.io/managed-by: Helm
+            app.kubernetes.io/name: hdx-oss-v2
+            app.kubernetes.io/version: 1.0.0
+        documentIndex: 0
+      - isSubset:
+          path: metadata.labels
+          content:
+            app.kubernetes.io/instance: RELEASE-NAME
+            app.kubernetes.io/managed-by: Helm
+            app.kubernetes.io/name: hdx-oss-v2
+            app.kubernetes.io/version: 1.0.0
+        documentIndex: 1
+      # Validate chart version format without exact match
+      - matchRegex:
+          path: metadata.labels["helm.sh/chart"]
+          pattern: ^hdx-oss-v2-\d+\.\d+\.\d+$
+        documentIndex: 0
+      - matchRegex:
+          path: metadata.labels["helm.sh/chart"]
+          pattern: ^hdx-oss-v2-\d+\.\d+\.\d+$
+        documentIndex: 1
 
   - it: should not render clickhouse secrets when clickhouse is disabled
     set: