Hide exceptions in ~Client

slabko · slabko · commit 27f59d66c3fa · 2025-12-10T08:47:47.000+01:00
`~Client` can throw producing all sorts for problems.
To avoid that, we ignore exceptions in the destructor,
similar to how it is done in std::fstream.
diff --git a/clickhouse/client.cpp b/clickhouse/client.cpp
@@ -289,8 +289,10 @@ Client::Impl::Impl(const ClientOptions& opts,
 }
 
 Client::Impl::~Impl() {
-    // Wrap up an insert if one is in progress.
-    EndInsert();
+    try {
+        EndInsert();
+    } catch (...) {
+    }
 }
 
 void Client::Impl::ExecuteQuery(Query query) {

Original file line number	Diff line number	Diff line change
`@@ -289,8 +289,10 @@ Client::Impl::Impl(const ClientOptions& opts,`
`289`	`289`	`}`
`290`	`290`
`291`	`291`	`Client::Impl::~Impl() {`
`292`		`- // Wrap up an insert if one is in progress.`
`293`		`- EndInsert();`
	`292`	`+ try {`
	`293`	`+ EndInsert();`
	`294`	`+ } catch (...) {`
	`295`	`+ }`
`294`	`296`	`}`
`295`	`297`
`296`	`298`	`void Client::Impl::ExecuteQuery(Query query) {`