Minor fixes: extra test case + remove excessive return.

Author: Enmk

clickhouse/columns/decimal.cpp

@@ -91,7 +91,6 @@ Int128 ColumnDecimal::At(size_t i) const {
             return data_->As<ColumnInt128>()->At(i);
         default:
             throw std::runtime_error("Invalid data_ column type in ColumnDecimal");
-            return 0;
     }
 }
 

clickhouse/columns/numeric.cpp

@@ -19,7 +19,7 @@ ColumnVector<T>::ColumnVector(const std::vector<T> & data)
 template <typename T>
 ColumnVector<T>::ColumnVector(std::vector<T> && data)
     : Column(Type::CreateSimple<T>())
-    , data_(data)
+    , data_(std::move(data))
 {
 }
 

ut/client_ut.cpp

@@ -767,10 +767,11 @@ TEST_P(ClientCase, DateTime64) {
                 return;
             }
 
+            const auto offset = total_rows - block.GetRowCount();
             ASSERT_EQ(1U, block.GetColumnCount());
             if (auto col = block[0]->As<ColumnDateTime64>()) {
                 for (size_t i = 0; i < col->Size(); ++i) {
-                    EXPECT_EQ(data[i], col->At(i)) << " at index: " << i;
+                    EXPECT_EQ(data[offset + i], col->At(i)) << " at index: " << i;
                 }
             }
         }

ut/columns_ut.cpp

@@ -304,6 +304,7 @@ TEST(ColumnsCase, DateTime64_Slice_OUTOFBAND) {
 
     EXPECT_EQ(column->Slice(0, data.size() + 1)->Size(), data.size());
     EXPECT_EQ(column->Slice(data.size() + 1, 1)->Size(), 0u);
+    EXPECT_EQ(column->Slice(data.size() / 2, data.size() / 2 + 2)->Size(), data.size() - data.size() / 2);
 }
 
 TEST(ColumnsCase, DateTime64_Swap_EXCEPTION) {

ut/performance_tests.cpp

@@ -80,7 +80,16 @@ class ColumnPerformanceTest : public ::testing::Test {
 
 TYPED_TEST_CASE_P(ColumnPerformanceTest);
 
+// Turns out this is the easiest way to skip test with current version of gtest
+#ifndef NDEBUG
+#  define SKIP_IN_DEBUG_BUILDS() do { std::cerr << "Test skipped...\n"; return; } while(0)
+#else
+#  define SKIP_IN_DEBUG_BUILDS() (void)(0)
+#endif
+
 TYPED_TEST_P(ColumnPerformanceTest, SaveAndLoad) {
+    SKIP_IN_DEBUG_BUILDS();
+
     auto column = InstantiateColumn<TypeParam>();
     using Timer = Timer<std::chrono::microseconds>;
 
@@ -155,6 +164,8 @@ TYPED_TEST_P(ColumnPerformanceTest, SaveAndLoad) {
 }
 
 TYPED_TEST_P(ColumnPerformanceTest, InsertAndSelect) {
+    SKIP_IN_DEBUG_BUILDS();
+
     using ColumnType = TypeParam;
     using Timer = Timer<std::chrono::microseconds>;