Fixed GenericColumnTest<ColumnDecimal>

Author: Enmk

ut/Column_ut.cpp

@@ -42,6 +42,8 @@ class GenericColumnTest : public testing::Test {
             return std::make_shared<ColumnFixedString>(12);
         } else if constexpr (std::is_same_v<ColumnType, ColumnDateTime64>) {
                 return std::make_shared<ColumnDateTime64>(3);
+        } else if constexpr (std::is_same_v<ColumnType, ColumnDecimal>) {
+                return std::make_shared<ColumnDecimal>(10, 5);
         } else {
             return std::make_shared<ColumnType>();
         }
@@ -99,8 +101,8 @@ using ValueColumns = ::testing::Types<
     , ColumnString, ColumnFixedString
     , ColumnDate, ColumnDateTime, ColumnDateTime64
     , ColumnIPv4, ColumnIPv6
-//    , ColumnInt128
-//    , ColumnDecimal
+    , ColumnInt128
+    , ColumnDecimal
     , ColumnUUID
 >;
 TYPED_TEST_SUITE(GenericColumnTest, ValueColumns);

ut/value_generators.cpp

@@ -84,8 +84,20 @@ std::vector<clickhouse::Int128> MakeInt128s() {
     };
 }
 
-std::vector<clickhouse::Int128> MakeDecimals(size_t /*precision*/, size_t /*scale*/) {
-    return MakeInt128s();
+std::vector<clickhouse::Int128> MakeDecimals(size_t /*precision*/, size_t scale) {
+    const auto scale_multiplier = static_cast<size_t>(std::pow(10, scale));
+    const auto rhs_value = 12345678910;
+
+    const std::vector<long long int> vals {0, 1, 2, 4, 8, 16, 32, 64, 128, 256, 512, 1024, 2048, 4096, 8192, 16384, 32768, 65536 - 1};
+
+    std::vector<clickhouse::Int128> result;
+    result.reserve(vals.size());
+
+    std::transform(vals.begin(), vals.end(), std::back_inserter(result), [scale_multiplier, rhs_value](const auto& value) {
+        return value * scale_multiplier + rhs_value % scale_multiplier;
+    });
+
+    return result;
 }
 
 std::string FooBarGenerator(size_t i) {

ut/value_generators.h

@@ -111,7 +111,10 @@ struct FromVectorGenerator {
     FromVectorGenerator(std::vector<T> data_)
         : data(std::move(data_)),
           random_generator(0, 0, data.size() - 1)
-    {}
+    {
+        if (data.size() == 0)
+            throw std::runtime_error("can't generate values from empty vector");
+    }
 
     auto operator()(size_t pos) {
         return data[random_generator(pos)];