Merge branch 'ClickHouse:main' into improve_site_vitals

Author: Blargian

.github/workflows/check-build.yml

@@ -14,47 +14,56 @@ on:
 jobs:
   stylecheck:
     runs-on: ubuntu-latest
-
+    strategy:
+      matrix:
+        check_type: [spellcheck, kbcheck]
     steps:
-      # Step 1: Check out the repository
-      - name: Check out repository
-        uses: actions/checkout@v4
-
-      # Step 2: Set up environment if required (e.g., installing Aspell)
+      - uses: actions/checkout@v4
       - name: Install Aspell
+        if: matrix.check_type == 'spellcheck'
         run: sudo apt-get update && sudo apt-get install -y aspell aspell-en
-
-      # Step 3: Run the spellcheck script
-      - name: Run spellcheck
-        run: |
-          ./scripts/check-doc-aspell
-        continue-on-error: true
-        id: spellcheck
-
-      # Step 4: Setup Python and dependencies for KB checker
       - name: Set up Python
+        if: matrix.check_type == 'kbcheck'
         uses: actions/setup-python@v5
         with:
           python-version: '3.x'
-
-      # Step 5: Install Python dependencies
       - name: Install dependencies
+        if: matrix.check_type == 'kbcheck'
         run: |
           python -m pip install --upgrade pip
           pip install -r 'scripts/knowledgebase-checker/requirements.txt'
 
-      # Step 5: Run knowledgebase article checker
-      - name: Check KB
-        run: |
-          ./scripts/knowledgebase-checker/knowledgebase_article_checker.py --kb-dir="knowledgebase"
-        continue-on-error: true
-        id: kbcheck
-
-      # Step 6: Fail the build if any script returns exit code 1
-      - name: Check exit code
+      - name: Run checks
+        id: check_step
         run: |
-          if [[ "${{ steps.spellcheck.outcome }}" == "failure" ]] || [[ "${{ steps.kbcheck.outcome }}" == "failure" ]]; then
-            echo "Style check failed. See the logs for details."
+          if [[ "${{ matrix.check_type }}" == "spellcheck" ]]; then
+            ./scripts/check-doc-aspell
+          exit_code=$?
+          elif [[ "${{ matrix.check_type }}" == "kbcheck" ]]; then
+            ./scripts/knowledgebase-checker/knowledgebase_article_checker.py --kb-dir="knowledgebase"
+          exit_code=$?
+          fi
+          
+          if [[ $exit_code -ne 0 ]]; then
+            echo "::error::${{ matrix.check_type }} check failed. See logs for details."
             exit 1
           fi
+
+      - name: Set check status
+        if: steps.check_step.outcome != 'success'
+        uses: actions/github-script@v6
+        with:
+          script: |
+            core.setFailed('${{ matrix.check_type }} check failed.');
+          
+  check_overall_status:
+    needs: stylecheck
+    runs-on: ubuntu-latest
+    if: always() # run the job even if stylecheck fails
+    steps:
+      - name: Check overall results
+        if: needs.stylecheck.result != 'success'
+        run: |
+          echo "::error::One or more checks of the style check failed."
+          exit 1
           

docs/en/_snippets/_users-and-roles-common.md

@@ -170,7 +170,7 @@ Roles are used to define groups of users for certain privileges instead of manag
 
 1. Log into the clickhouse client using the `clickhouse_admin` user
 
-   ```
+   ```bash
    clickhouse-client --user clickhouse_admin --password password
    ```
 
@@ -194,7 +194,7 @@ Roles are used to define groups of users for certain privileges instead of manag
 
 3. Log into the ClickHouse client using the `column_user` user
 
-   ```
+   ```bash
    clickhouse-client --user column_user --password password
    ```
 
@@ -245,7 +245,7 @@ Roles are used to define groups of users for certain privileges instead of manag
 
 1. Log into the ClickHouse client using `row_user`
 
-   ```
+   ```bash
    clickhouse-client --user row_user --password password
    ```
 
@@ -295,7 +295,7 @@ For example, if one `role1` allows for only select on `column1` and `role2` allo
 
 4. Log into the ClickHouse client using `row_and_column_user`
 
-   ```
+   ```bash
    clickhouse-client --user row_and_column_user --password password;
    ```
 

docs/en/chdb/guides/clickhouse-local.md

@@ -98,7 +98,7 @@ from chdb import session as chs
 
 Initialize a session pointing to `demo..chdb`:
 
-```
+```python
 sess = chs.Session("demo.chdb")
 ```
 

docs/en/chdb/guides/querying-pandas.md

@@ -321,7 +321,7 @@ from chdb import session as chs
 
 Initialize a session:
 
-```
+```python
 sess = chs.Session()
 ```
 

docs/en/cloud/manage/account-close.md

@@ -39,11 +39,13 @@ below.
 3. Click the Help button (question mark in the upper right corner of the screen).
 4. Under 'Support' click 'Create case.'
 5. In the 'Create new case' screen, enter the following:
-```
+
+```text
 Priority: Severity 3
 Subject: Please close my ClickHouse account
 Description: We would appreciate it if you would share a brief note about why you are cancelling.
 ```
+
 5. Click 'Create new case'
 6. We will close your account and send a confirmation email to let you know when it is complete.