Skip to content

Commit a6a834e

Browse files
BlargianBlargian
committed
incorporate review feedback
1 parent 61cf70e commit a6a834e

File tree

4 files changed

+25
-16
lines changed

4 files changed

+25
-16
lines changed

‎src/components/ColorModeToggler/index.jsx

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -16,13 +16,13 @@ export default function ColorModeToggle({className = ''}) {
1616
return (
1717
<button className={`${styles.colorModeButton} ${className}`} onClick={updateColor}>
1818
{colorMode === 'dark' ? (
19-
<svg xmlns="http://www.w3.org/2000/svg" fill="none" width="16" height="16" viewBox="0 0 24 24" strokeWidth={1.5} stroke="currentColor" className="w-6 h-6">
20-
<path strokeLinecap="round" strokeLinejoin="round" d="M21.752 15.002A9.718 9.718 0 0118 15.75c-5.385 0-9.75-4.365-9.75-9.75 0-1.33.266-2.597.748-3.752A9.753 9.753 0 003 11.25C3 16.635 7.365 21 12.75 21a9.753 9.753 0 009.002-5.998z" />
19+
<svg xmlns="http://www.w3.org/2000/svg" fill="none" width="20" height="20" viewBox="0 0 24 24" strokeWidth={1.5} stroke="currentColor" className="w-6 h-6" strokeLinecap="round" strokeLinejoin="round">
20+
<path strokeLinecap="round" strokeLinejoin="round" d="M18.3945 13.0269C18.7245 12.8719 19.0765 13.1969 18.9845 13.5499C18.6705 14.7519 18.0535 15.8959 17.1035 16.8459C14.2825 19.6669 9.76953 19.7259 7.02153 16.9779C4.27353 14.2299 4.33353 9.71589 7.15453 6.89489C8.10453 5.94489 9.24753 5.32789 10.4505 5.01389C10.8035 4.92189 11.1275 5.27389 10.9735 5.60389C9.97153 7.74289 10.3005 10.3049 11.9975 12.0019C13.6935 13.6999 16.2555 14.0289 18.3945 13.0269V13.0269Z" />
2121
</svg>
22-
2322
) : (
24-
<svg width="16" height="16" viewBox="0 0 16 16" fill="none" xmlns="http://www.w3.org/2000/svg">
25-
<path d="M8.7227 0.724664C8.7227 0.330045 8.39191 0 8.0036 0C7.60809 0 7.2773 0.330045 7.2773 0.724664V2.18834C7.2773 2.57578 7.60809 2.90583 8.0036 2.90583C8.39191 2.90583 8.7227 2.57578 8.7227 2.18834V0.724664ZM11.5991 3.4009C11.3258 3.67354 11.3258 4.13274 11.6063 4.41256C11.8796 4.6852 12.347 4.69238 12.6274 4.40538L13.6629 3.3722C13.9434 3.09238 13.9362 2.62601 13.6629 2.34619C13.3897 2.07354 12.9222 2.08072 12.649 2.35336L11.5991 3.4009ZM3.37258 4.40538C3.64584 4.6852 4.11326 4.6852 4.38652 4.41256C4.66697 4.14709 4.66697 3.66637 4.4009 3.4009L3.3582 2.35336C3.09213 2.08789 2.61753 2.07354 2.34427 2.34619C2.07101 2.62601 2.06382 3.09238 2.33708 3.36502L3.37258 4.40538ZM7.9964 11.774C10.0602 11.774 11.7717 10.0664 11.7717 8C11.7717 5.93363 10.0602 4.22601 7.9964 4.22601C5.93258 4.22601 4.22112 5.93363 4.22112 8C4.22112 10.0664 5.93258 11.774 7.9964 11.774ZM7.9964 10.4395C6.65888 10.4395 5.55146 9.33453 5.55146 8C5.55146 6.66547 6.65888 5.56054 7.9964 5.56054C9.33393 5.56054 10.4413 6.66547 10.4413 8C10.4413 9.33453 9.33393 10.4395 7.9964 10.4395ZM15.2809 8.71749C15.6692 8.71749 16 8.38744 16 8C16 7.60538 15.6692 7.28251 15.2809 7.28251H13.8211C13.4328 7.28251 13.102 7.60538 13.102 8C13.102 8.38744 13.4328 8.71749 13.8211 8.71749H15.2809ZM0.719101 7.28251C0.330787 7.28251 0 7.60538 0 8C0 8.38744 0.330787 8.71749 0.719101 8.71749H2.17888C2.57438 8.71749 2.90517 8.38744 2.90517 8C2.90517 7.60538 2.57438 7.28251 2.17888 7.28251H0.719101ZM12.6202 11.5946C12.347 11.322 11.8796 11.322 11.5991 11.5946C11.3258 11.8744 11.3258 12.3336 11.6063 12.6135L12.649 13.6538C12.9294 13.9265 13.3897 13.9193 13.6701 13.6395C13.9434 13.3668 13.9434 12.9076 13.6629 12.6278L12.6202 11.5946ZM2.33708 12.6206C2.05663 12.9004 2.05663 13.3668 2.3227 13.6395C2.60315 13.9121 3.07056 13.9193 3.34382 13.6466L4.38652 12.6135C4.66697 12.3336 4.66697 11.8744 4.4009 11.6018C4.12045 11.322 3.65303 11.322 3.37258 11.5946L2.33708 12.6206ZM8.7227 13.8117C8.7227 13.4242 8.39191 13.0942 8.0036 13.0942C7.60809 13.0942 7.2773 13.4242 7.2773 13.8117V15.2753C7.2773 15.6628 7.60809 16 8.0036 16C8.39191 16 8.7227 15.6628 8.7227 15.2753V13.8117Z" fill="currentColor"/>
23+
<svg xmlns="http://www.w3.org/2000/svg" fill="none" width="20" height="20" viewBox="0 0 24 24" strokeWidth={1.5} stroke="currentColor" className="w-6 h-6" strokeLinecap="round" strokeLinejoin="round">
24+
<path strokeLinecap="round" strokeLinejoin="round" d="M12 2v2M12 20v2M4.22 4.22l1.42 1.42M18.36 18.36l1.42 1.42M2 12h2M20 12h2M4.22 19.78l1.42-1.42M18.36 5.64l1.42-1.42" />
25+
<circle cx="12" cy="12" r="5" strokeLinecap="round" strokeLinejoin="round" />
2626
</svg>
2727
)}
2828
</button>

‎src/components/MobileSideBarMenu/Content.jsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -252,7 +252,7 @@ const MobileSideBarMenuContents = ({ className, onClick, onClose, sidebar, path,
252252
<div className={styles.headerActions}>
253253
<MobileLanguagePicker onLanguageChange={handleLanguageChange} />
254254
<ColorModeToggle/>
255-
<IconClose width={10} height={10} onClick={onClose || onClick} style={{"align-self":"center"}}/>
255+
<div className={styles.iconClose}><IconClose width={12} height={12} onClick={onClose || onClick} /></div>
256256
</div>
257257
</div>
258258
<div className={styles.bottomLevel}>

‎src/components/MobileSideBarMenu/mobileLanguagePicker.module.scss

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -118,7 +118,7 @@
118118
}
119119

120120
&:hover {
121-
background: var(--ifm-color-emphasis-200);
121+
background: var(--ifm-menu-color-background-active);
122122
text-decoration: none;
123123
color: black;
124124
}
@@ -131,12 +131,12 @@
131131
}
132132

133133
&.languageOptionActive {
134-
background: #e8e4ec;
134+
background: var(--ifm-menu-color-background-active) ;
135135
color: black;
136136
font-weight: 600;
137137

138138
&:hover {
139-
background: #e8e4ec;
139+
background: var(--ifm-menu-color-background-active) ;
140140
color: black;
141141
}
142142
}
@@ -151,35 +151,35 @@
151151
[data-theme='dark'] {
152152
.languageButton {
153153
&:hover {
154-
background: var(--ifm-color-emphasis-300);
154+
background: var(--ifm-menu-color-background-active);
155155
}
156156
}
157157

158158
.languageDropdown {
159-
background: var(--ifm-background-color);
159+
background: #1f1f1c;
160160
border-color: var(--ifm-color-emphasis-400);
161161
box-shadow: 0 10px 25px rgba(0, 0, 0, 0.3);
162162
}
163163

164164
.languageOption {
165-
background: var(--ifm-background-color);
165+
background: #1f1f1c;
166166

167167
&:hover {
168-
background: #414141;
168+
background: var(--ifm-menu-color-background-active);
169169
color: white;
170170
}
171171

172172
&:focus {
173-
background: #414141;
173+
background: var(--ifm-menu-color-background-active);
174174
color: white;
175175
}
176176

177177
&.languageOptionActive {
178-
background: #414141;
178+
background: var(--ifm-menu-color-background-active);
179179
color: white;
180180

181181
&:hover {
182-
background: #414141;
182+
background: var(--ifm-menu-color-background-active);
183183
color: white;
184184
}
185185
}

‎src/components/MobileSideBarMenu/styles.module.scss

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -232,3 +232,12 @@
232232
[data-theme="light"] .docsMobileMenuActive {
233233
background-color: white;
234234
}
235+
236+
.iconClose {
237+
padding: 0.3rem 0.5rem !important;
238+
border-radius: 6px;
239+
}
240+
241+
.iconClose:hover {
242+
background: var(--ifm-menu-color-background-active) !important;
243+
}

0 commit comments

Comments
 (0)