Skip to content

Commit b0e2861

Browse files
authored
Merge pull request #3427 from Blargian/fix_anchors_5_mar
fix autogenerate settings and fix remaining broken link
2 parents e7043e5 + dd49bdd commit b0e2861

File tree

2 files changed

+4
-7
lines changed

2 files changed

+4
-7
lines changed

docs/guides/best-practices/sparse-primary-indexes.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1018,7 +1018,7 @@ ClickHouse selected only 39 index marks, instead of 1076 when generic exclusion
10181018
Note that the additional table is optimized for speeding up the execution of our example query filtering on URLs.
10191019

10201020

1021-
Similar to the [bad performance](/best-practices/sparse-primary-indexes#secondary-key-columns-can-not-be-inefficient) of that query with our [original table](#a-table-with-a-primary-key), our [example query filtering on `UserIDs`](#the-primary-index-is-used-for-selecting-granules) will not run very effectively with the new additional table, because UserID is now the second key column in the primary index of that table and therefore ClickHouse will use generic exclusion search for granule selection, which is [not very effective for similarly high cardinality](/guides/best-practices/sparse-primary-indexes#generic-exclusion-search-algorithm) of UserID and URL.
1021+
Similar to the [bad performance](/guides/best-practices/sparse-primary-indexes#secondary-key-columns-can-not-be-inefficient) of that query with our [original table](#a-table-with-a-primary-key), our [example query filtering on `UserIDs`](#the-primary-index-is-used-for-selecting-granules) will not run very effectively with the new additional table, because UserID is now the second key column in the primary index of that table and therefore ClickHouse will use generic exclusion search for granule selection, which is [not very effective for similarly high cardinality](/guides/best-practices/sparse-primary-indexes#generic-exclusion-search-algorithm) of UserID and URL.
10221022
Open the details box for specifics.
10231023

10241024
<details>

scripts/settings/autogenerate-settings.sh

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -82,7 +82,7 @@ These settings are autogenerated from [source](https://github.com/ClickHouse/Cli
8282
' AS prefix
8383
SELECT prefix || (SELECT groupConcat(*) FROM main_content)
8484
INTO OUTFILE 'settings-formats.md' TRUNCATE FORMAT LineAsString
85-
" || { echo "Failed to Autogenerate Format settings"; exit 1; }
85+
" > /dev/null || { echo "Failed to Autogenerate Format settings"; exit 1; }
8686

8787
# Autogenerate settings
8888
./clickhouse -q "
@@ -119,18 +119,15 @@ All below settings are also available in table [system.settings](/docs/operation
119119
' AS prefix
120120
SELECT prefix || (SELECT groupConcat(*) FROM main_content)
121121
INTO OUTFILE 'settings.md' TRUNCATE FORMAT LineAsString
122-
" || { echo "Failed to Autogenerate Core settings"; exit 1; }
122+
" > /dev/null || { echo "Failed to Autogenerate Core settings"; exit 1; }
123123

124124
mv settings-formats.md "$root/docs/operations/settings" || { echo "Failed to move generated settings-format.md"; exit 1; }
125125
mv settings.md "$root/docs/operations/settings" || { echo "Failed to move generated settings.md"; exit 1; }
126126

127127
echo "[$SCRIPT_NAME] Auto-generation of settings markdown pages completed successfully"
128128

129129
# perform cleanup
130-
rm -rf "$tmp_dir"/settings-formats.md
131-
rm -rf "$tmp_dir"/settings.md
132-
rm -rf "$tmp_dir"/FormatFactorySettings.h
133-
rm -rf "$tmp_dir"/Settings.cpp
130+
rm -rf "$tmp_dir"/{settings-formats.md,settings.md,FormatFactorySettings.h,Settings.cpp,clickhouse}
134131

135132
echo "[$SCRIPT_NAME] Autogenerating settings completed"
136133

0 commit comments

Comments
 (0)