Make search button work before JavaScript loads #5326
+99
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace DocSearchButton with a progressive enhancement approach: - Use native <a href="search"> link that works without JavaScript - After React hydrates, intercept clicks to open DocSearch modal - Add CSS to style the link element as a button This fixes the issue where search was unusable on slow connections until all scripts (~25MB) finished loading. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
3 Skipped Deployments
|
Member
Author
|
I tried to test it, but didn't end up validating. Please check if it's alright. |
Member
Author
|
@Blargian, I need help - for some reason it goes to |
Member
Thanks @alexey-milovidov, sorry for the delay. On my to-do list for first thing tomorrow. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Replace DocSearchButton with a progressive enhancement approach:
This fixes the issue where search was unusable on slow connections until all scripts (~25MB) finished loading.
Checklist