-
Notifications
You must be signed in to change notification settings - Fork 407
Fix menu overflow #3177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix menu overflow #3177
Conversation
|
I'm onboard with renaming them. Reference sounds a bit generic, will it be clear to users what this is? |
|
@crisalbu specifically the new layout of top menus https://clickhouse-docs-euxc8gggb-clickhouse.vercel.app/docs vs https://clickhouse.com/docs |
|
I can see the improvement, much better now. As the screen becomes more narrow and the menu items are more crammed, perhaps we can have |
@crisalbu Added. Would you mind taking a look please: https://clickhouse-docs-nxj0u7mte-clickhouse.vercel.app/docs/ |
|
I was wondering, how bout we make the nav items left aligned, like the top navigation. I would even go as far as using the same menu components we have for the top navigation, to make it feel more consistent. If Dale is ok with using |
|
@gingerwizard @crisalbu thoughts please on left aligned nav items: https://clickhouse-docs-6w6a3er2n-clickhouse.vercel.app/docs/ Personally I think it's an improvement with left-aligned items. I've tried to style the docs menu to look similar (more similar than it was, at least) to the top menu but for some reason it was implemented as a completely separate component to the top menu. Reworking the secondary menu to use the same components as the top menu will take a fair amount of effort. I'm mainly concerned with fixing the overflow issue at this stage. Let's look at reworking the secondary menu further at a later stage. |
crisalbu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
@crisalbu sorry for the delay, we hit a bump in the road with vercel builds yesterday so couldn't share the build. Here are the latest changes: https://clickhouse-docs-ps0f1dhfr-clickhouse.vercel.app/docs/ Have added a few more breakpoints so that:
Does this work? |
…ocs into fix_top_level_menu
|
@crisalbu fixed (and some other small issues i noticed) - https://clickhouse-docs-cx95xobw9-clickhouse.vercel.app/ |
| .click-button { | ||
| padding: 8px; | ||
| } | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit:
| .githubStars { | ||
| display: none; | ||
| } | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
address
| [data-theme="light"] .docsNavDropdownContainer { | ||
| background-color: white; | ||
| } | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit:
gingerwizard
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor



Summary
Temporary fix to the horrible top level navigation.
I think we can save some more space as well by renaming menu items:
"Getting started" -> "Get Started"
"Managing Data" -> "Manage Data"
"SQL Reference" -> "Reference" (It's not only about SQL)Checklist