Skip to content

Conversation

@gingerwizard
Copy link
Collaborator

Summary

iframes and divs show in search drop down. We should probably remove all html from the markdown - ill follow up.

Checklist

@Blargian Blargian merged commit 32e07a9 into main Feb 12, 2025
5 checks passed
@DamianMaslanka5
Copy link
Contributor

@gingerwizard I think using something like Beautiful Soup to parse html might be easier to maintain and less error-prone than parsing markdown with regex.

@gingerwizard
Copy link
Collaborator Author

gingerwizard commented Feb 13, 2025

Yes aware. Was quick fix as I want to evaluate effect on relevancy of removing all html - hence comment. We measure changes in content and shift in ndcg vs user judged results

@gingerwizard gingerwizard deleted the fix_div_search branch March 13, 2025 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants